webrtc/modules/audio_coding/audio_network_adaptor/fec_controller_rplr_based.cc - Issue 2906663002: FecControler disables FEC when *below* threshold

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_coding/audio_network_adaptor/fec_controller_rplr_based.cc

Issue 2906663002: FecControler disables FEC when *below* threshold (Closed)

Patch Set: . Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/audio_coding/audio_network_adaptor/fec_controller_plr_based_unittest.cc ('k') | webrtc/modules/audio_coding/audio_network_adaptor/fec_controller_rplr_based_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_coding/audio_network_adaptor/fec_controller_rplr_based.cc

diff --git a/webrtc/modules/audio_coding/audio_network_adaptor/fec_controller_rplr_based.cc b/webrtc/modules/audio_coding/audio_network_adaptor/fec_controller_rplr_based.cc

index d21e8bef52cdf3bbc7f13e4abc0dced0dc61ff57..a51c277b665222934bbe24a50aaec04ae522706c 100644

--- a/webrtc/modules/audio_coding/audio_network_adaptor/fec_controller_rplr_based.cc

+++ b/webrtc/modules/audio_coding/audio_network_adaptor/fec_controller_rplr_based.cc

@@ -68,8 +68,8 @@ bool FecControllerRplrBased::FecDisablingDecision() const {

if (!uplink_bandwidth_bps_ || !uplink_recoverable_packet_loss_) {

return false;

} else {

- // Disable when below the curve or exactly on it.

- return !config_.fec_disabling_threshold.IsAboveCurve(

+ // Disable when below the curve.

+ return config_.fec_disabling_threshold.IsBelowCurve(

{static_cast<float>(*uplink_bandwidth_bps_),

*uplink_recoverable_packet_loss_});

}