Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Side by Side Diff: third_party/polymer/components/iron-ajax/CONTRIBUTING.md

Issue 2906483004: [pinpoint] Add iron-form and paper-checkbox to polymer components. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1
2 <!-- 1 <!--
3 This file is autogenerated based on 2 This file is autogenerated based on
4 https://github.com/PolymerElements/ContributionGuide/blob/master/CONTRIBUTING.md 3 https://github.com/PolymerElements/ContributionGuide/blob/master/CONTRIBUTING.md
5 4
6 If you edit that file, it will get updated everywhere else. 5 If you edit that file, it will get updated everywhere else.
7 If you edit this file, your changes will get overridden :) 6 If you edit this file, your changes will get overridden :)
8 7
9 You can however override the jsbin link with one that's customized to this 8 You can however override the jsbin link with one that's customized to this
10 specific element: 9 specific element:
11 10
12 jsbin=https://jsbin.com/cagaye/edit?html,output 11 jsbin=https://jsbin.com/zeriha/2/edit?html,output
13 --> 12 -->
13
14 # Polymer Elements 14 # Polymer Elements
15 ## Guide for Contributors 15 ## Guide for Contributors
16 16
17 Polymer Elements are built in the open, and the Polymer authors eagerly encourag e any and all forms of community contribution. When contributing, please follow these guidelines: 17 Polymer Elements are built in the open, and the Polymer authors eagerly encourag e any and all forms of community contribution. When contributing, please follow these guidelines:
18 18
19 ### Filing Issues 19 ### Filing Issues
20 20
21 **If you are filing an issue to request a feature**, please provide a clear desc ription of the feature. It can be helpful to describe answers to the following q uestions: 21 **If you are filing an issue to request a feature**, please provide a clear desc ription of the feature. It can be helpful to describe answers to the following q uestions:
22 22
23 1. **Who will use the feature?** _“As someone filling out a form…”_ 23 1. **Who will use the feature?** _“As someone filling out a form…”_
(...skipping 15 matching lines...) Expand all
39 39
40 The page turns pink. 40 The page turns pink.
41 41
42 ## Steps to reproduce 42 ## Steps to reproduce
43 43
44 1. Put a `paper-foo` element in the page. 44 1. Put a `paper-foo` element in the page.
45 2. Open the page in a web browser. 45 2. Open the page in a web browser.
46 3. Click the `paper-foo` element. 46 3. Click the `paper-foo` element.
47 ``` 47 ```
48 48
49 2. **A reduced test case that demonstrates the problem.** If possible, please i nclude the test case as a JSBin. Start with this template to easily import and u se relevant Polymer Elements: [https://jsbin.com/cagaye/edit?html,output](https: //jsbin.com/cagaye/edit?html,output). 49 2. **A reduced test case that demonstrates the problem.** If possible, please i nclude the test case as a JSBin. Start with this template to easily import and u se relevant Polymer Elements: [https://jsbin.com/zeriha/2/edit?html,output](http s://jsbin.com/zeriha/2/edit?html,output).
50 50
51 3. **A list of browsers where the problem occurs.** This can be skipped if the problem is the same across all browsers. 51 3. **A list of browsers where the problem occurs.** This can be skipped if the problem is the same across all browsers.
52 52
53 ### Submitting Pull Requests 53 ### Submitting Pull Requests
54 54
55 **Before creating a pull request**, please ensure that an issue exists for the c orresponding change in the pull request that you intend to make. **If an issue d oes not exist, please create one per the guidelines above**. The goal is to disc uss the design and necessity of the proposed change with Polymer authors and com munity before diving into a pull request. 55 **Before creating a pull request**, please ensure that an issue exists for the c orresponding change in the pull request that you intend to make. **If an issue d oes not exist, please create one per the guidelines above**. The goal is to disc uss the design and necessity of the proposed change with Polymer authors and com munity before diving into a pull request.
56 56
57 When submitting pull requests, please provide: 57 When submitting pull requests, please provide:
58 58
59 1. **A reference to the corresponding issue** or issues that will be closed by the pull request. Please refer to these issues in the pull request description u sing the following syntax: 59 1. **A reference to the corresponding issue** or issues that will be closed by the pull request. Please refer to these issues in the pull request description u sing the following syntax:
60 60
61 ```markdown 61 ```markdown
62 (For a single issue) 62 (For a single issue)
63 Fixes #20 63 Fixes #20
64 64
65 (For multiple issues) 65 (For multiple issues)
66 Fixes #32, fixes #40 66 Fixes #32, fixes #40
67 ``` 67 ```
68 68
69 2. **A succinct description of the design** used to fix any related issues. For example: 69 2. **A succinct description of the design** used to fix any related issues. For example:
70 70
71 ```markdown 71 ```markdown
72 This fixes #20 by removing styles that leaked which would cause the page to tur n pink whenever `paper-foo` is clicked. 72 This fixes #20 by removing styles that leaked which would cause the page to tur n pink whenever `paper-foo` is clicked.
73 ``` 73 ```
74 74
75 3. **At least one test for each bug fixed or feature added** as part of the pul l request. Pull requests that fix bugs or add features without accompanying test s will not be considered. 75 3. **At least one test for each bug fixed or feature added** as part of the pul l request. Pull requests that fix bugs or add features without accompanying test s will not be considered.
76 76
77 If a proposed change contains multiple commits, please [squash commits](https:// www.google.com/url?q=http://blog.steveklabnik.com/posts/2012-11-08-how-to-squash -commits-in-a-github-pull-request) to as few as is necessary to succinctly expre ss the change. A Polymer author can help you squash commits, so don’t be afraid to ask us if you need help with that! 77 If a proposed change contains multiple commits, please [squash commits](https:// www.google.com/url?q=http://blog.steveklabnik.com/posts/2012-11-08-how-to-squash -commits-in-a-github-pull-request) to as few as is necessary to succinctly expre ss the change. A Polymer author can help you squash commits, so don’t be afraid to ask us if you need help with that!
OLDNEW
« no previous file with comments | « third_party/polymer/components/iron-ajax/.travis.yml ('k') | third_party/polymer/components/iron-ajax/README.md » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698