webrtc/api/video/video_frame.h - Issue 2906053002: Update I420Buffer to new VideoFrameBuffer interface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/api/video/video_frame.h

Issue 2906053002: Update I420Buffer to new VideoFrameBuffer interface (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/api/video/video_frame.h

diff --git a/webrtc/api/video/video_frame.h b/webrtc/api/video/video_frame.h

index 82c348d07e57a8cf64d6e91809f8e57212fba4dc..3ee381b09146ec423d47fc52da3f1fe447a350e3 100644

--- a/webrtc/api/video/video_frame.h

+++ b/webrtc/api/video/video_frame.h

@@ -98,7 +98,7 @@ class VideoFrame {

// TODO(nisse): Deprecated.

// Return true if the frame is stored in a texture.

bool is_texture() const {

- return video_frame_buffer()->native_handle() != nullptr;

+ return video_frame_buffer()->type() == VideoFrameBuffer::Type::kNative;

nisse-webrtc 2017/05/29 08:22:22 Do you agree this method should be deleted?

magjed_webrtc 2017/05/29 12:12:06 Yeah, but this function is not a big issue in my o

}

private: