Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/custom/V8DevToolsHostCustom.cpp

Issue 2905763003: Rollback ContextMenu (Closed)
Patch Set: Rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/BUILD.gn ('k') | third_party/WebKit/Source/core/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/bindings/core/v8/custom/V8DevToolsHostCustom.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/custom/V8DevToolsHostCustom.cpp b/third_party/WebKit/Source/bindings/core/v8/custom/V8DevToolsHostCustom.cpp
index fbc6d6edfe2ca1b81eaee354c9f5c5e7a5c3a95f..d97f7eacd3c7bc05c4d39a928a52cc5b3a877bbb 100644
--- a/third_party/WebKit/Source/bindings/core/v8/custom/V8DevToolsHostCustom.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/custom/V8DevToolsHostCustom.cpp
@@ -82,9 +82,8 @@ static bool PopulateContextMenuItems(v8::Isolate* isolate,
continue;
String type_string = ToCoreStringWithNullCheck(type.As<v8::String>());
if (type_string == "separator") {
- ContextMenuItem item(ContextMenuItem(kSeparatorType,
- kContextMenuItemCustomTagNoAction,
- String(), String()));
+ ContextMenuItem item(ContextMenuItem(
+ kSeparatorType, kContextMenuItemCustomTagNoAction, String()));
menu.AppendItem(item);
} else if (type_string == "subMenu" && sub_items->IsArray()) {
ContextMenu sub_menu;
@@ -95,7 +94,7 @@ static bool PopulateContextMenuItems(v8::Isolate* isolate,
TOSTRING_DEFAULT(V8StringResource<kTreatNullAsNullString>, label_string,
label, false);
ContextMenuItem item(kSubmenuType, kContextMenuItemCustomTagNoAction,
- label_string, String(), &sub_menu);
+ label_string, &sub_menu);
menu.AppendItem(item);
} else {
int32_t int32_id;
@@ -107,7 +106,7 @@ static bool PopulateContextMenuItems(v8::Isolate* isolate,
label, false);
ContextMenuItem menu_item(
(type_string == "checkbox" ? kCheckableActionType : kActionType),
- typed_id, label_string, String());
+ typed_id, label_string);
if (checked->IsBoolean())
menu_item.SetChecked(checked.As<v8::Boolean>()->Value());
if (enabled->IsBoolean())
« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/BUILD.gn ('k') | third_party/WebKit/Source/core/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698