Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(506)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 2905243002: [PIP] Add picture in picture flag and switch. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/flag_descriptions.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 3000 matching lines...) Expand 10 before | Expand all | Expand 10 after
3011 FEATURE_VALUE_TYPE(features::kMacRTL)}, 3011 FEATURE_VALUE_TYPE(features::kMacRTL)},
3012 #endif // defined(OS_MACOSX) 3012 #endif // defined(OS_MACOSX)
3013 3013
3014 #if defined(OS_CHROMEOS) 3014 #if defined(OS_CHROMEOS)
3015 {"disable-new-virtual-keyboard-behavior", 3015 {"disable-new-virtual-keyboard-behavior",
3016 flag_descriptions::kDisableNewVirtualKeyboardBehaviorName, 3016 flag_descriptions::kDisableNewVirtualKeyboardBehaviorName,
3017 flag_descriptions::kDisableNewVirtualKeyboardBehaviorDescription, kOsCrOS, 3017 flag_descriptions::kDisableNewVirtualKeyboardBehaviorDescription, kOsCrOS,
3018 SINGLE_DISABLE_VALUE_TYPE(switches::kDisableNewVirtualKeyboardBehavior)}, 3018 SINGLE_DISABLE_VALUE_TYPE(switches::kDisableNewVirtualKeyboardBehavior)},
3019 #endif // defined(OS_CHROMEOS) 3019 #endif // defined(OS_CHROMEOS)
3020 3020
3021 #if !defined(OS_ANDROID) && !defined(OS_IOS)
3022 {"enable-picture-in-picture",
3023 flag_descriptions::kEnablePictureInPictureName,
3024 flag_descriptions::kEnablePictureInPictureDescription, kOsDesktop,
3025 SINGLE_VALUE_TYPE(switches::kEnablePictureInPicture)},
3026 #endif // !defined(OS_ANDROID) && !defined(OS_IOS)
3027
3021 // NOTE: Adding new command-line switches requires adding corresponding 3028 // NOTE: Adding new command-line switches requires adding corresponding
3022 // entries to enum "LoginCustomFlags" in histograms/enums.xml. See note in 3029 // entries to enum "LoginCustomFlags" in histograms/enums.xml. See note in
3023 // enums.xml and don't forget to run AboutFlagsHistogramTest unit test. 3030 // enums.xml and don't forget to run AboutFlagsHistogramTest unit test.
3024 }; 3031 };
3025 3032
3026 class FlagsStateSingleton { 3033 class FlagsStateSingleton {
3027 public: 3034 public:
3028 FlagsStateSingleton() 3035 FlagsStateSingleton()
3029 : flags_state_(kFeatureEntries, arraysize(kFeatureEntries)) {} 3036 : flags_state_(kFeatureEntries, arraysize(kFeatureEntries)) {}
3030 ~FlagsStateSingleton() {} 3037 ~FlagsStateSingleton() {}
(...skipping 205 matching lines...) Expand 10 before | Expand all | Expand 10 after
3236 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0; 3243 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0;
3237 3244
3238 const FeatureEntry* GetFeatureEntries(size_t* count) { 3245 const FeatureEntry* GetFeatureEntries(size_t* count) {
3239 *count = arraysize(kFeatureEntries); 3246 *count = arraysize(kFeatureEntries);
3240 return kFeatureEntries; 3247 return kFeatureEntries;
3241 } 3248 }
3242 3249
3243 } // namespace testing 3250 } // namespace testing
3244 3251
3245 } // namespace about_flags 3252 } // namespace about_flags
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/flag_descriptions.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698