Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(875)

Issue 2904793002: Allow setting breakpoints in literal function initializers of fields. (Closed)

Created:
3 years, 7 months ago by sivachandra
Modified:
3 years, 7 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Allow setting breakpoints in literal function initializers of fields. Fixes #29581 when the VM parser is used. R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/3b9cf7351bb0e92e0789eb68b37d130886644bd8

Patch Set 1 #

Patch Set 2 : Add comments #

Total comments: 8

Patch Set 3 : Address comments #

Total comments: 8

Patch Set 4 : Address comments on patch set 3. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+261 lines, -88 lines) Patch
M runtime/vm/debugger.h View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M runtime/vm/debugger.cc View 1 2 3 4 chunks +126 lines, -86 lines 0 comments Download
M runtime/vm/debugger_test.cc View 1 2 3 1 chunk +76 lines, -0 lines 0 comments Download
M runtime/vm/parser.h View 1 2 chunks +10 lines, -0 lines 0 comments Download
M runtime/vm/parser.cc View 1 2 3 3 chunks +45 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
sivachandra
3 years, 7 months ago (2017-05-24 05:09:21 UTC) #3
siva
Have you tried this with the --dfe option to see if this works? If not ...
3 years, 7 months ago (2017-05-24 19:51:23 UTC) #4
sivachandra
Addressed comments; PTAL The new test added in this CL fails with --dfe. Will fix ...
3 years, 7 months ago (2017-05-26 07:17:58 UTC) #5
siva
LGTM with some comments. https://codereview.chromium.org/2904793002/diff/40001/runtime/vm/debugger.cc File runtime/vm/debugger.cc (right): https://codereview.chromium.org/2904793002/diff/40001/runtime/vm/debugger.cc#newcode2711 runtime/vm/debugger.cc:2711: const Array& functions = Array::Handle(zone, ...
3 years, 7 months ago (2017-05-26 17:18:40 UTC) #6
sivachandra
Addressed comments. Will submit shortly. https://codereview.chromium.org/2904793002/diff/40001/runtime/vm/debugger.cc File runtime/vm/debugger.cc (right): https://codereview.chromium.org/2904793002/diff/40001/runtime/vm/debugger.cc#newcode2711 runtime/vm/debugger.cc:2711: const Array& functions = ...
3 years, 7 months ago (2017-05-26 20:27:35 UTC) #7
sivachandra
3 years, 7 months ago (2017-05-26 20:43:39 UTC) #10
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
3b9cf7351bb0e92e0789eb68b37d130886644bd8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698