third_party/WebKit/Source/core/css/cssom/CSSStyleImageValueTest.cpp - Issue 2903413002: Restructure type tracking in StyleValues to work better with new numeric types

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/cssom/CSSStyleImageValueTest.cpp

Issue 2903413002: Restructure type tracking in StyleValues to work better with new numeric types (Closed)

Patch Set: rebase Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/cssom/CSSResourceValueTest.cpp ('k') | third_party/WebKit/Source/core/css/cssom/CSSStyleValue.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/cssom/CSSStyleImageValueTest.cpp

diff --git a/third_party/WebKit/Source/core/css/cssom/CSSStyleImageValueTest.cpp b/third_party/WebKit/Source/core/css/cssom/CSSStyleImageValueTest.cpp

index 939e40bb321ec4f651cfb79d70f97b9b6326eacb..40a261357dd6dde5a3fb5f8c03286fbeba1b3ae5 100644

--- a/third_party/WebKit/Source/core/css/cssom/CSSStyleImageValueTest.cpp

+++ b/third_party/WebKit/Source/core/css/cssom/CSSStyleImageValueTest.cpp

@@ -23,7 +23,7 @@ class FakeCSSStyleImageValue : public CSSStyleImageValue {

LayoutSize ImageLayoutSize() const override { return layout_size_; }

CSSValue* ToCSSValue() const override { return nullptr; }

- StyleValueType GetType() const override { return kUnknown; }

+ StyleValueType GetType() const override { return kUnknownType; }

private:

bool cache_pending_;