Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Unified Diff: third_party/WebKit/Source/core/css/CSSProperties.json5

Issue 2903413002: Restructure type tracking in StyleValues to work better with new numeric types (Closed)
Patch Set: rebase Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/CSSProperties.json5
diff --git a/third_party/WebKit/Source/core/css/CSSProperties.json5 b/third_party/WebKit/Source/core/css/CSSProperties.json5
index 3938290e5bbbc8b487e07c1af2dd2c8f199961cd..3802ea953e8143b8903c40853e008ad14c28b30b 100644
--- a/third_party/WebKit/Source/core/css/CSSProperties.json5
+++ b/third_party/WebKit/Source/core/css/CSSProperties.json5
@@ -140,18 +140,27 @@
// - separator
// The property supports a list of values, and when there is more than one,
// it is separated with this character.
- // - supports_percentage
- // The property supports percentage types.
typedom_types: {
default: [],
+ valid_type: "list",
+ valid_values: [
+ "Angle",
+ "Flex",
+ "Frequency",
+ "Length",
+ "Number",
+ "Percent",
+ "Position",
+ "Resolution",
+ "Time",
+ "Transform",
+ "Unparsed",
+ "Image"
+ ],
},
separator: {
valid_values: [",", " ", "/"],
},
- supports_percentage: {
- default: false,
- valid_type: "bool",
- },
// Flags which go into CSSPropertyMetadata:
// - interpolable
@@ -719,6 +728,7 @@
initial: "InitialBorderWidth",
interpolable: true,
keywords: ["thin", "medium", "thick"],
+ typedom_types: ["Length"],
field_template: "storage_only",
include_paths: ["platform/LayoutUnit.h"],
type_name: "LayoutUnit",
@@ -791,6 +801,7 @@
initial: "InitialBorderWidth",
interpolable: true,
keywords: ["thin", "medium", "thick"],
+ typedom_types: ["Length"],
field_template: "storage_only",
include_paths: ["platform/LayoutUnit.h"],
type_name: "LayoutUnit",
@@ -823,6 +834,7 @@
initial: "InitialBorderWidth",
interpolable: true,
keywords: ["thin", "medium", "thick"],
+ typedom_types: ["Length"],
field_template: "storage_only",
include_paths: ["platform/LayoutUnit.h"],
type_name: "LayoutUnit",
@@ -879,7 +891,7 @@
initial: "InitialBorderWidth",
interpolable: true,
keywords: ["thin", "medium", "thick"],
- supports_percentage: true,
+ typedom_types: ["Length"],
field_template: "storage_only",
include_paths: ["platform/LayoutUnit.h"],
type_name: "LayoutUnit",
@@ -893,7 +905,6 @@
converter: "ConvertLengthOrAuto",
interpolable: true,
keywords: ["auto"],
- supports_percentage: true,
field_template: "external",
include_paths: ["platform/Length.h"],
type_name: "Length",
@@ -1264,7 +1275,6 @@
is_descriptor: true,
interpolable: true,
keywords: ["auto", "fit-content", "min-content", "max-content"],
- supports_percentage: true,
field_template: "external",
include_paths: ["platform/Length.h"],
type_name: "Length",
@@ -1329,7 +1339,6 @@
converter: "ConvertLengthOrAuto",
interpolable: true,
keywords: ["auto"],
- supports_percentage: true,
field_template: "external",
include_paths: ["platform/Length.h"],
type_name: "Length",
@@ -1790,7 +1799,6 @@
converter: "ConvertLengthOrAuto",
interpolable: true,
keywords: ["auto"],
- supports_percentage: true,
field_template: "external",
include_paths: ["platform/Length.h"],
type_name: "Length",
@@ -2159,7 +2167,6 @@
converter: "ConvertLengthOrAuto",
interpolable: true,
keywords: ["auto"],
- supports_percentage: true,
field_template: "external",
include_paths: ["platform/Length.h"],
type_name: "Length",
@@ -2728,7 +2735,6 @@
is_descriptor: true,
interpolable: true,
keywords: ["auto", "fit-content", "min-content", "max-content"],
- supports_percentage: true,
field_template: "external",
include_paths: ["platform/Length.h"],
type_name: "Length",

Powered by Google App Engine
This is Rietveld 408576698