MacViews: Tweak kDragToEndIfOutsideVerticalBounds for single line fields.

ui/views/controls/label_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/controls/label.h"
 
 #include <stddef.h>
 
 #include "base/command_line.h"
 #include "base/i18n/rtl.h"
@@ skipping 81 matching lines @@
   return clipboard_text;
 }
 
 enum class SecondaryUiMode { NON_MD, MD };
 
 std::string SecondaryUiModeToString(
     const ::testing::TestParamInfo<SecondaryUiMode>& info) {
   return info.param == SecondaryUiMode::MD ? "MD" : "NonMD";
 }
 
+// Makes an RTL string by mapping 0..6 to [א,ב,ג,ד,ה,ו,ז].
+base::string16 ToRTL(const char* ascii) {
+  base::string16 rtl;
+  for (const char* c = ascii; *c; ++c) {
+    if (*c >= '0' && *c <= '6')
+      rtl += L'\x5d0' + (*c - '0');
+    else
+      rtl += static_cast<base::string16::value_type>(*c);
+  }
+  return rtl;
+}
+
 }  // namespace
 
 class LabelTest : public ViewsTestBase {
  public:
   LabelTest() {}
 
   // Called after ViewsTestBase is set up. ViewsTestBase initializes the
   // MaterialDesignController, so this allows a subclass to influence settings
   // used for the remainder of SetUp().
   virtual void OnBaseSetUp() {}
@@ skipping 30 matching lines @@
  private:
   Label* label_ = nullptr;
   Widget widget_;
 
   DISALLOW_COPY_AND_ASSIGN(LabelTest);
 };
 
 // Test fixture for text selection related tests.
 class LabelSelectionTest : public LabelTest {
  public:
+  // Alias this long identifier for more readable tests.
+  static constexpr bool kExtends =
+      gfx::RenderText::kDragToEndIfOutsideVerticalBounds;
+
+  // Some tests use cardinal directions to index an array of points above and
+  // below the label in either visual direction.
+  enum { NW, NORTH, NE, SE, SOUTH, SW };
+
   LabelSelectionTest() {}
 
   // LabelTest overrides:
   void SetUp() override {
 #if defined(OS_MACOSX)
     // On Mac, by default RenderTextMac is used for labels which does not
     // support text selection. Instead use RenderTextHarfBuzz for selection
     // related tests. TODO(crbug.com/661394): Remove this once Mac also uses
     // RenderTextHarfBuzz for Labels.
     base::CommandLine::ForCurrentProcess()->AppendSwitch(
@@ skipping 865 matching lines @@
 
   PerformMouseDragTo(GetCursorPoint(7));
   EXPECT_STR_EQ("cd\nef", GetSelectedText());
 
   PerformMouseDragTo(gfx::Point(-5, GetCursorPoint(6).y()));
   EXPECT_STR_EQ("cd\n", GetSelectedText());
 
   PerformMouseDragTo(gfx::Point(100, GetCursorPoint(6).y()));
   EXPECT_STR_EQ("cd\nefgh", GetSelectedText());
 
-  PerformMouseDragTo(gfx::Point(GetCursorPoint(3).x(), -5));
-  EXPECT_STR_EQ(gfx::RenderText::kDragToEndIfOutsideVerticalBounds ? "ab" : "c",
-                GetSelectedText());
+  const gfx::Point points[] = {
+      {GetCursorPoint(1).x(), -5},   // NW.
+      {GetCursorPoint(2).x(), -5},   // NORTH.
+      {GetCursorPoint(3).x(), -5},   // NE.
+      {GetCursorPoint(8).x(), 100},  // SE.
+      {GetCursorPoint(7).x(), 100},  // SOUTH.
+      {GetCursorPoint(6).x(), 100},  // SW.
+  };
+  constexpr const char* kExtendLeft = "ab";
+  constexpr const char* kExtendRight = "cd\nefgh";
 
-  PerformMouseDragTo(gfx::Point(GetCursorPoint(7).x(), 100));
-  EXPECT_STR_EQ(gfx::RenderText::kDragToEndIfOutsideVerticalBounds ? "cd\nefgh"
-                                                                   : "cd\nef",
-                GetSelectedText());
+  // For multiline, N* extends left, S* extends right.
+  PerformMouseDragTo(points[NW]);
+  EXPECT_STR_EQ(kExtends ? kExtendLeft : "b", GetSelectedText());
+  PerformMouseDragTo(points[NORTH]);
+  EXPECT_STR_EQ(kExtends ? kExtendLeft : "", GetSelectedText());
+  PerformMouseDragTo(points[NE]);
+  EXPECT_STR_EQ(kExtends ? kExtendLeft : "c", GetSelectedText());
+  PerformMouseDragTo(points[SE]);
+  EXPECT_STR_EQ(kExtends ? kExtendRight : "cd\nefg", GetSelectedText());
+  PerformMouseDragTo(points[SOUTH]);
+  EXPECT_STR_EQ(kExtends ? kExtendRight : "cd\nef", GetSelectedText());
+  PerformMouseDragTo(points[SW]);
+  EXPECT_STR_EQ(kExtends ? kExtendRight : "cd\ne", GetSelectedText());
+}
+
+// Single line fields consider the x offset as well. Ties go to the right.
+TEST_F(LabelSelectionTest, MouseDragSingleLineLTR) {
+  label()->SetText(ASCIIToUTF16("abcdef"));
+  label()->SizeToPreferredSize();
+  ASSERT_TRUE(label()->SetSelectable(true));
+  PerformMousePress(GetCursorPoint(2));
+  const gfx::Point points[] = {
+      {GetCursorPoint(1).x(), -5},   // NW.
+      {GetCursorPoint(2).x(), -5},   // NORTH.
+      {GetCursorPoint(3).x(), -5},   // NE.
+      {GetCursorPoint(3).x(), 100},  // SE.
+      {GetCursorPoint(2).x(), 100},  // SOUTH.
+      {GetCursorPoint(1).x(), 100},  // SW.
+  };
+  constexpr const char* kExtendLeft = "ab";
+  constexpr const char* kExtendRight = "cdef";
+
+  // For single line, western directions extend left, all others extend right.
+  PerformMouseDragTo(points[NW]);
+  EXPECT_STR_EQ(kExtends ? kExtendLeft : "b", GetSelectedText());
+  PerformMouseDragTo(points[NORTH]);
+  EXPECT_STR_EQ(kExtends ? kExtendRight : "", GetSelectedText());
+  PerformMouseDragTo(points[NE]);
+  EXPECT_STR_EQ(kExtends ? kExtendRight : "c", GetSelectedText());
+  PerformMouseDragTo(points[SE]);
+  EXPECT_STR_EQ(kExtends ? kExtendRight : "c", GetSelectedText());
+  PerformMouseDragTo(points[SOUTH]);
+  EXPECT_STR_EQ(kExtends ? kExtendRight : "", GetSelectedText());
+  PerformMouseDragTo(points[SW]);
+  EXPECT_STR_EQ(kExtends ? kExtendLeft : "b", GetSelectedText());
 }
 
 TEST_F(LabelSelectionTest, MouseDragMultilineRTL) {
   label()->SetMultiLine(true);
-  label()->SetText(WideToUTF16(L"\x5d0\x5d1\x5d2\n\x5d3\x5d4\x5d5"));
+  label()->SetText(ToRTL("012\n345"));
+  // Sanity check.
+  EXPECT_EQ(WideToUTF16(L"\x5d0\x5d1\x5d2\n\x5d3\x5d4\x5d5"), label()->text());
+
   label()->SizeToPreferredSize();
   ASSERT_TRUE(label()->SetSelectable(true));
   ASSERT_EQ(2u, GetLineCount());
 
-  PerformMousePress(GetCursorPoint(1));
+  PerformMousePress(GetCursorPoint(1));  // Note: RTL drag starts at 1, not 2.
   PerformMouseDragTo(GetCursorPoint(0));
-  EXPECT_EQ(WideToUTF16(L"\x5d0"), GetSelectedText());
+  EXPECT_EQ(ToRTL("0"), GetSelectedText());
 
   PerformMouseDragTo(GetCursorPoint(6));
-  EXPECT_EQ(WideToUTF16(L"\x5d1\x5d2\n\x5d3\x5d4"), GetSelectedText());
+  EXPECT_EQ(ToRTL("12\n34"), GetSelectedText());
 
   PerformMouseDragTo(gfx::Point(-5, GetCursorPoint(6).y()));
-  EXPECT_EQ(WideToUTF16(L"\x5d1\x5d2\n\x5d3\x5d4\x5d5"), GetSelectedText());
+  EXPECT_EQ(ToRTL("12\n345"), GetSelectedText());
 
   PerformMouseDragTo(gfx::Point(100, GetCursorPoint(6).y()));
-  EXPECT_EQ(WideToUTF16(L"\x5d1\x5d2\n"), GetSelectedText());
+  EXPECT_EQ(ToRTL("12\n"), GetSelectedText());
 
-  PerformMouseDragTo(gfx::Point(GetCursorPoint(2).x(), -5));
-  EXPECT_EQ(gfx::RenderText::kDragToEndIfOutsideVerticalBounds
-                ? WideToUTF16(L"\x5d0")
-                : WideToUTF16(L"\x5d1"),
-            GetSelectedText());
+  const gfx::Point points[] = {
+      {GetCursorPoint(2).x(), -5},   // NW: Now towards the end of the string.
+      {GetCursorPoint(1).x(), -5},   // NORTH,
+      {GetCursorPoint(0).x(), -5},   // NE: Towards the start.
+      {GetCursorPoint(4).x(), 100},  // SE.
+      {GetCursorPoint(5).x(), 100},  // SOUTH.
+      {GetCursorPoint(6).x(), 100},  // SW.
+  };
 
-  PerformMouseDragTo(gfx::Point(GetCursorPoint(6).x(), 100));
-  EXPECT_EQ(gfx::RenderText::kDragToEndIfOutsideVerticalBounds
-                ? WideToUTF16(L"\x5d1\x5d2\n\x5d3\x5d4\x5d5")
-                : WideToUTF16(L"\x5d1\x5d2\n\x5d3\x5d4"),
-            GetSelectedText());
+  // Visual right, so to the beginning of the string for RTL.
+  const base::string16 extend_right = ToRTL("0");
+  const base::string16 extend_left = ToRTL("12\n345");
+
+  // For multiline, N* extends right, S* extends left.
+  PerformMouseDragTo(points[NW]);
+  EXPECT_EQ(kExtends ? extend_right : ToRTL("1"), GetSelectedText());
+  PerformMouseDragTo(points[NORTH]);
+  EXPECT_EQ(kExtends ? extend_right : ToRTL(""), GetSelectedText());
+  PerformMouseDragTo(points[NE]);
+  EXPECT_EQ(kExtends ? extend_right : ToRTL("0"), GetSelectedText());
+  PerformMouseDragTo(points[SE]);
+  EXPECT_EQ(kExtends ? extend_left : ToRTL("12\n"), GetSelectedText());
+  PerformMouseDragTo(points[SOUTH]);
+  EXPECT_EQ(kExtends ? extend_left : ToRTL("12\n3"), GetSelectedText());
+  PerformMouseDragTo(points[SW]);
+  EXPECT_EQ(kExtends ? extend_left : ToRTL("12\n34"), GetSelectedText());
+}
+
+TEST_F(LabelSelectionTest, MouseDragSingleLineRTL) {
+  label()->SetText(ToRTL("0123456"));
+  label()->SizeToPreferredSize();
+  ASSERT_TRUE(label()->SetSelectable(true));
+
+  PerformMousePress(GetCursorPoint(1));
+  const gfx::Point points[] = {
+      {GetCursorPoint(2).x(), -5},   // NW.
+      {GetCursorPoint(1).x(), -5},   // NORTH.
+      {GetCursorPoint(0).x(), -5},   // NE.
+      {GetCursorPoint(0).x(), 100},  // SE.
+      {GetCursorPoint(1).x(), 100},  // SOUTH.
+      {GetCursorPoint(2).x(), 100},  // SW.
+  };
+
+  // Visual right, so to the beginning of the string for RTL.
+  const base::string16 extend_right = ToRTL("0");
+  const base::string16 extend_left = ToRTL("123456");
+
+  // For single line, western directions extend left, all others extend right.
+  PerformMouseDragTo(points[NW]);
+  EXPECT_EQ(kExtends ? extend_left : ToRTL("1"), GetSelectedText());
+  PerformMouseDragTo(points[NORTH]);
+  EXPECT_EQ(kExtends ? extend_right : ToRTL(""), GetSelectedText());
+  PerformMouseDragTo(points[NE]);
+  EXPECT_EQ(kExtends ? extend_right : ToRTL("0"), GetSelectedText());
+  PerformMouseDragTo(points[SE]);
+  EXPECT_EQ(kExtends ? extend_right : ToRTL("0"), GetSelectedText());
+  PerformMouseDragTo(points[SOUTH]);
+  EXPECT_EQ(kExtends ? extend_right : ToRTL(""), GetSelectedText());
+  PerformMouseDragTo(points[SW]);
+  EXPECT_EQ(kExtends ? extend_left : ToRTL("1"), GetSelectedText());
 }
 
 // Verify the initially selected word on a double click, remains selected on
 // mouse dragging.
 TEST_F(LabelSelectionTest, MouseDragWord) {
   label()->SetText(ASCIIToUTF16("Label drag word"));
   label()->SizeToPreferredSize();
   ASSERT_TRUE(label()->SetSelectable(true));
 
   PerformClick(GetCursorPoint(8));
@@ skipping 100 matching lines @@
   EXPECT_FALSE(IsMenuCommandEnabled(IDS_APP_SELECT_ALL));
 }
 
 INSTANTIATE_TEST_CASE_P(,
                         MDLabelTest,
                         ::testing::Values(SecondaryUiMode::MD,
                                           SecondaryUiMode::NON_MD),
                         &SecondaryUiModeToString);
 
 }  // namespace views