Add unit tests for qp parser.

webrtc/modules/video_coding/codecs/test/videoprocessor.cc

 /*
  *  Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 129 matching lines @@
       encoded_frame_writer_(encoded_frame_writer),
       decoded_frame_writer_(decoded_frame_writer),
       bit_rate_factor_(config.codec_settings->maxFramerate * 0.001 * 8),
       initialized_(false),
       last_encoded_frame_num_(-1),
       last_decoded_frame_num_(-1),
       first_key_frame_has_been_excluded_(false),
       last_decoded_frame_buffer_(0, analysis_frame_reader->FrameLength()),
       stats_(stats),
       num_dropped_frames_(0),
-      num_spatial_resizes_(0) {
+      num_spatial_resizes_(0),
+      qp_encoder_(0),
+      qp_bitstream_(0) {
   RTC_DCHECK(encoder);
   RTC_DCHECK(decoder);
   RTC_DCHECK(packet_manipulator);
   RTC_DCHECK(analysis_frame_reader);
   RTC_DCHECK(analysis_frame_writer);
   RTC_DCHECK(stats);
 
   frame_infos_.reserve(num_frames_);
 }
 
@@ skipping 192 matching lines @@
   frame_stat->encoding_successful = true;
   frame_stat->encoded_frame_length_in_bytes = encoded_image._length;
   frame_stat->frame_number = frame_number;
   frame_stat->frame_type = encoded_image._frameType;
   frame_stat->qp = encoded_image.qp_;
   frame_stat->bit_rate_in_kbps = encoded_image._length * bit_rate_factor_;
   frame_stat->total_packets =
       encoded_image._length / config_.networking_config.packet_size_in_bytes +
       1;
 
+  // Get qp from the encoder and the parser.
+  qp_encoder_ = encoded_image.qp_;

[brandtr, 2017/05/26 07:18:45]

Move to after line 351, and add to |frame_info| instead.

[jianj, 2017/05/26 18:20:27]

Done.

+  if (codec == kVideoCodecVP8) {
+    vp8::GetQp(encoded_image._buffer, encoded_image._length, &qp_bitstream_);

[brandtr, 2017/05/26 07:18:45]

These too :)

[jianj, 2017/05/26 18:20:27]

Done.

+  } else if (codec == kVideoCodecVP9) {
+    vp9::GetQp(encoded_image._buffer, encoded_image._length, &qp_bitstream_);
+  }
+
   // Simulate packet loss.
   bool exclude_this_frame = false;
   if (encoded_image._frameType == kVideoFrameKey) {
     // Only keyframes can be excluded.
     switch (config_.exclude_frame_types) {
       case kExcludeOnlyFirstKeyFrame:
         if (!first_key_frame_has_been_excluded_) {
           first_key_frame_has_been_excluded_ = true;
           exclude_this_frame = true;
         }
@@ skipping 43 matching lines @@
         analysis_frame_writer_->WriteFrame(last_decoded_frame_buffer_.data()));
     if (decoded_frame_writer_) {
       RTC_DCHECK_EQ(last_decoded_frame_buffer_.size(),
                     decoded_frame_writer_->FrameLength());
       RTC_CHECK(
           decoded_frame_writer_->WriteFrame(last_decoded_frame_buffer_.data()));
     }
   }
 }
 
+int VideoProcessorImpl::GetQpFromEncoder() {

[brandtr, 2017/05/26 07:18:45]

After moving the declarations in the .h file, please move these definitions to
have the same relative order to the other member functions in the .cc file.

[jianj, 2017/05/26 18:20:27]

Done.

+  return qp_encoder_;
+}
+
+int VideoProcessorImpl::GetQpFromBitstream() {
+  return qp_bitstream_;
+}
+
 void VideoProcessorImpl::FrameDecoded(const VideoFrame& image) {
   // For the highest measurement accuracy of the decode time, the start/stop
   // time recordings should wrap the Decode call as tightly as possible.
   int64_t decode_stop_ns = rtc::TimeNanos();
 
   // Update frame information and statistics.
   int frame_number = TimestampToFrameNumber(image.timestamp());
   RTC_DCHECK_LT(frame_number, frame_infos_.size());
   FrameInfo* frame_info = &frame_infos_[frame_number];
   frame_info->decoded_width = image.width();
@@ skipping 61 matching lines @@
   if (decoded_frame_writer_) {
     RTC_DCHECK_EQ(extracted_length, decoded_frame_writer_->FrameLength());
     RTC_CHECK(decoded_frame_writer_->WriteFrame(extracted_buffer.data()));
   }
 
   last_decoded_frame_buffer_ = std::move(extracted_buffer);
 }
 
 }  // namespace test
 }  // namespace webrtc