Annotation unique id updated in error_reporter.cc.

Annotation unique id updated in error_reporter.cc.

Annotation unique_id of components/certificate_reporting/error_reporter.cc was
not unique and is updated.

BUG=656607
Review-Url: https://codereview.chromium.org/2902893003
Cr-Commit-Position: refs/heads/master@{#474942}
Committed: https://chromium.googlesource.com/chromium/src/+/68b458d1d5bc4915b97bcaf34dbf130367f9c36b

[Ramin Halavati, 2017-05-24 07:08:25]

rhalavati@chromium.org changed reviewers:
+ estark@chromium.org

[Ramin Halavati, 2017-05-24 07:08:25]

Emily,

The unique id of this annotation was not really unique and already used in
"components/safe_browsing/base_ping_manager.cc".
I've changed it, do you agree or you'd suggest something else?

We are working on presubmit and unittests for annotations that will prevent
these issues in future.

[estark, 2017-05-26 01:34:28]

lgtm with a suggestion

https://codereview.chromium.org/2902893003/diff/1/components/certificate_repo...
File components/certificate_reporting/error_reporter.cc (right):

https://codereview.chromium.org/2902893003/diff/1/components/certificate_repo...
components/certificate_reporting/error_reporter.cc:103:
net::DefineNetworkTrafficAnnotation("safe_browsing_error_reporting", R"(
maybe safe_browsing_certificate_error_reporting ?

[Ramin Halavati, 2017-05-26 04:53:07]

Thank you, Done.

https://codereview.chromium.org/2902893003/diff/1/components/certificate_repo...
File components/certificate_reporting/error_reporter.cc (right):

https://codereview.chromium.org/2902893003/diff/1/components/certificate_repo...
components/certificate_reporting/error_reporter.cc:103:
net::DefineNetworkTrafficAnnotation("safe_browsing_error_reporting", R"(
On 2017/05/26 01:34:28, estark wrote:
> maybe safe_browsing_certificate_error_reporting ?

Done.

[Ramin Halavati, 2017-05-26 04:53:12]

The CQ bit was checked by rhalavati@chromium.org

[Ramin Halavati, 2017-05-26 04:53:13]

The patchset sent to the CQ was uploaded after l-g-t-m from estark@chromium.org
Link to the patchset: https://codereview.chromium.org/2902893003/#ps20001
(title: "Annotation unique id updated.")

[commit-bot: I haz the power, 2017-05-26 04:53:52]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 06:31:21]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495774392941620,
"parent_rev": "9f63aac7dcb8a3d51eb3743bf352b06e75153f11", "commit_rev":
"68b458d1d5bc4915b97bcaf34dbf130367f9c36b"}

[commit-bot: I haz the power, 2017-05-26 06:31:32]

Description was changed from

==========
Annotation unique id updated in error_reporter.cc.

Annotation unique_id of components/certificate_reporting/error_reporter.cc was
not unique and is updated.

BUG=656607
==========

to

==========
Annotation unique id updated in error_reporter.cc.

Annotation unique_id of components/certificate_reporting/error_reporter.cc was
not unique and is updated.

BUG=656607

Review-Url: https://codereview.chromium.org/2902893003
Cr-Commit-Position: refs/heads/master@{#474942}
Committed:
https://chromium.googlesource.com/chromium/src/+/68b458d1d5bc4915b97bcaf34dbf...
==========

[commit-bot: I haz the power, 2017-05-26 06:31:33]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/68b458d1d5bc4915b97bcaf34dbf...