Create unit tests for RtpDemuxer

webrtc/call/BUILD.gn

Index: webrtc/call/BUILD.gn
diff --git a/webrtc/call/BUILD.gn b/webrtc/call/BUILD.gn
index a6afe302409949a2a6609bba13e1232ba320bfe9..69fc949ccabe9d7dd53c0abcb55fdd96bfb11fcf 100644
--- a/webrtc/call/BUILD.gn
+++ b/webrtc/call/BUILD.gn
@@ -89,6 +89,7 @@ if (rtc_include_tests) {
       "bitrate_estimator_tests.cc",
       "call_unittest.cc",
       "flexfec_receive_stream_unittest.cc",
+      "rtp_demuxer_unittest.cc",  # TODO(eladalon): Not really video-engine specific.

[danilchap, 2017/05/24 17:14:02]

same can be said about all other unittests in this source_set.
so may be move this comment closer to the part that need changing.

also, it is better to phrase TODOs in a form of what should be done.

[eladalon, 2017/05/25 08:00:05]

Moved. Would we normally also file a bug for this, or is a TODO sufficient?

[nisse-webrtc, 2017/05/29 07:58:22]

Probably are no hard rules. Speaking generally, in one way, TODO is a
light-weight tool to use when for some reason one can't be bothered to file a
bug. And it can be used to link to a relevant bug, if there is one. To file a
bug, I think one would need to have a wider scope than just moving a file or two
around, and figure out what's the desired organization of these build targets. 

Looking at this case, to me, it seems appropriate that the call_tests target
includes unit tests for whatever code happens to be located in the call/
directory. Now the rtp demuxer should be moved out of this directory at some
point, together with the rest of the rtp transport controller code which is
under development, but that's not really a problem with this build target or
this BUILD.gn file.

       "rtx_receive_stream_unittest.cc",
     ]
     deps = [