ios/chrome/browser/passwords/ios_chrome_save_password_infobar_delegate.mm - Issue 2900693002: [Password Manager] Convert |pending_login_managers_| to an array of scoped_refptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/passwords/ios_chrome_save_password_infobar_delegate.mm

Issue 2900693002: [Password Manager] Convert |pending_login_managers_| to an array of scoped_refptr (Closed)

Patch Set: Rebase Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ios/chrome/browser/passwords/ios_chrome_save_password_infobar_delegate.h ('k') | ios/chrome/browser/passwords/ios_chrome_update_password_infobar_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/passwords/ios_chrome_save_password_infobar_delegate.mm

diff --git a/ios/chrome/browser/passwords/ios_chrome_save_password_infobar_delegate.mm b/ios/chrome/browser/passwords/ios_chrome_save_password_infobar_delegate.mm

index 4d0cec2e21f6bfe6067eb620ab28fdf9b3229535..7e444c5f36298684ef9aa01c965e7d071c8f6b23 100644

--- a/ios/chrome/browser/passwords/ios_chrome_save_password_infobar_delegate.mm

+++ b/ios/chrome/browser/passwords/ios_chrome_save_password_infobar_delegate.mm

@@ -22,7 +22,7 @@ using password_manager::PasswordFormManager;

void IOSChromeSavePasswordInfoBarDelegate::Create(

bool is_smart_lock_branding_enabled,

infobars::InfoBarManager* infobar_manager,

- std::unique_ptr<PasswordFormManager> form_to_save) {

+ scoped_refptr<PasswordFormManager> form_to_save) {

DCHECK(infobar_manager);

auto delegate = base::WrapUnique(new IOSChromeSavePasswordInfoBarDelegate(

is_smart_lock_branding_enabled, std::move(form_to_save)));

@@ -34,7 +34,7 @@ IOSChromeSavePasswordInfoBarDelegate::~IOSChromeSavePasswordInfoBarDelegate() {}

IOSChromeSavePasswordInfoBarDelegate::IOSChromeSavePasswordInfoBarDelegate(

bool is_smart_lock_branding_enabled,

- std::unique_ptr<PasswordFormManager> form_to_save)

+ scoped_refptr<PasswordFormManager> form_to_save)

: IOSChromePasswordManagerInfoBarDelegate(is_smart_lock_branding_enabled,

std::move(form_to_save)) {}