components/password_manager/core/browser/stub_password_manager_client.h - Issue 2900693002: [Password Manager] Convert |pending_login_managers_| to an array of scoped_refptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/stub_password_manager_client.h

Issue 2900693002: [Password Manager] Convert |pending_login_managers_| to an array of scoped_refptr (Closed)

Patch Set: Rebase Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/password_manager_unittest.cc ('k') | components/password_manager/core/browser/stub_password_manager_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/stub_password_manager_client.h

diff --git a/components/password_manager/core/browser/stub_password_manager_client.h b/components/password_manager/core/browser/stub_password_manager_client.h

index 77c740befb5d0887c04381798b1206e751357347..4cfb70ee8b0632e103bf1ee17412765ed1e653e9 100644

--- a/components/password_manager/core/browser/stub_password_manager_client.h

+++ b/components/password_manager/core/browser/stub_password_manager_client.h

@@ -22,7 +22,7 @@ class StubPasswordManagerClient : public PasswordManagerClient {

// PasswordManagerClient:

bool PromptUserToSaveOrUpdatePassword(

- std::unique_ptr<PasswordFormManager> form_to_save,

+ scoped_refptr<PasswordFormManager> form_to_save,

bool update_password) override;

bool PromptUserToChooseCredentials(

std::vector<std::unique_ptr<autofill::PasswordForm>> local_forms,

@@ -37,7 +37,7 @@ class StubPasswordManagerClient : public PasswordManagerClient {

const autofill::PasswordForm& form) override;

void NotifyStorePasswordCalled() override;

void AutomaticPasswordSave(

- std::unique_ptr<PasswordFormManager> saved_manager) override;

+ scoped_refptr<PasswordFormManager> saved_manager) override;

PrefService* GetPrefs() override;

PasswordStore* GetPasswordStore() const override;

const GURL& GetLastCommittedEntryURL() const override;