Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Unified Diff: components/password_manager/core/browser/password_manager_client.h

Issue 2900693002: [Password Manager] Convert |pending_login_managers_| to an array of scoped_refptr (Closed)
Patch Set: Rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_manager_client.h
diff --git a/components/password_manager/core/browser/password_manager_client.h b/components/password_manager/core/browser/password_manager_client.h
index 7004aee79abcdbf891c14210ec25f3bebbf38feb..405202d28f92bf3acab080ece0f28b37ea031d4c 100644
--- a/components/password_manager/core/browser/password_manager_client.h
+++ b/components/password_manager/core/browser/password_manager_client.h
@@ -9,6 +9,7 @@
#include "base/callback.h"
#include "base/macros.h"
+#include "base/memory/ref_counted.h"
#include "components/autofill/core/common/password_form.h"
#include "components/password_manager/core/browser/credentials_filter.h"
#include "components/password_manager/core/browser/password_store.h"
@@ -91,7 +92,7 @@ class PasswordManagerClient {
// and form_to_save.pending_credentials() should correspond to the credential
// that was overidden.
virtual bool PromptUserToSaveOrUpdatePassword(
- std::unique_ptr<PasswordFormManager> form_to_save,
+ scoped_refptr<PasswordFormManager> form_to_save,
bool update_password) = 0;
// Informs the embedder of a password forms that the user should choose from.
@@ -136,7 +137,7 @@ class PasswordManagerClient {
// Called when a password is saved in an automated fashion. Embedder may
// inform the user that this save has occured.
virtual void AutomaticPasswordSave(
- std::unique_ptr<PasswordFormManager> saved_form_manager) = 0;
+ scoped_refptr<PasswordFormManager> saved_form_manager) = 0;
// Called when a password is autofilled. |best_matches| contains the
// PasswordForm into which a password was filled: the client may choose to

Powered by Google App Engine
This is Rietveld 408576698