Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(682)

Unified Diff: components/password_manager/core/browser/credential_manager_password_form_manager_unittest.cc

Issue 2900693002: [Password Manager] Convert |pending_login_managers_| to an array of scoped_refptr (Closed)
Patch Set: Rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/credential_manager_password_form_manager_unittest.cc
diff --git a/components/password_manager/core/browser/credential_manager_password_form_manager_unittest.cc b/components/password_manager/core/browser/credential_manager_password_form_manager_unittest.cc
index 88caa117d772fa4a573639161b2a0e000bc819ee..df684b2727276c23ac001e9fdc4015ae1768530d 100644
--- a/components/password_manager/core/browser/credential_manager_password_form_manager_unittest.cc
+++ b/components/password_manager/core/browser/credential_manager_password_form_manager_unittest.cc
@@ -50,12 +50,14 @@ class CredentialManagerPasswordFormManagerTest : public testing::Test {
TEST_F(CredentialManagerPasswordFormManagerTest, AbortEarly) {
PasswordForm observed_form;
MockDelegate delegate;
- auto form_manager = base::MakeUnique<CredentialManagerPasswordFormManager>(
- &client_, driver_.AsWeakPtr(), observed_form,
- base::MakeUnique<PasswordForm>(observed_form), &delegate,
- base::MakeUnique<StubFormSaver>(), base::MakeUnique<FakeFormFetcher>());
-
- auto deleter = [&form_manager]() { form_manager.reset(); };
+ auto form_manager =
+ base::MakeRefCounted<CredentialManagerPasswordFormManager>(
+ &client_, driver_.AsWeakPtr(), observed_form,
+ base::MakeUnique<PasswordForm>(observed_form), &delegate,
+ base::MakeUnique<StubFormSaver>(),
+ base::MakeUnique<FakeFormFetcher>());
+
+ auto deleter = [&form_manager]() { form_manager = nullptr; };
// Simulate that the PasswordStore responded to the FormFetcher. As a result,
// |form_manager| should call the delegate's OnProvisionalSaveComplete, which

Powered by Google App Engine
This is Rietveld 408576698