Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Unified Diff: chrome/browser/ui/passwords/manage_passwords_state.cc

Issue 2900693002: [Password Manager] Convert |pending_login_managers_| to an array of scoped_refptr (Closed)
Patch Set: Rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/passwords/manage_passwords_state.cc
diff --git a/chrome/browser/ui/passwords/manage_passwords_state.cc b/chrome/browser/ui/passwords/manage_passwords_state.cc
index b99c9fcad0a4088d05f1406d7a26b8b53d95fb08..81e1421f27ccc984aa752523a517f41d2aab6a8c 100644
--- a/chrome/browser/ui/passwords/manage_passwords_state.cc
+++ b/chrome/browser/ui/passwords/manage_passwords_state.cc
@@ -80,7 +80,7 @@ ManagePasswordsState::ManagePasswordsState()
ManagePasswordsState::~ManagePasswordsState() {}
void ManagePasswordsState::OnPendingPassword(
- std::unique_ptr<password_manager::PasswordFormManager> form_manager) {
+ scoped_refptr<password_manager::PasswordFormManager> form_manager) {
ClearData();
form_manager_ = std::move(form_manager);
local_credentials_forms_ =
@@ -92,7 +92,7 @@ void ManagePasswordsState::OnPendingPassword(
}
void ManagePasswordsState::OnUpdatePassword(
- std::unique_ptr<password_manager::PasswordFormManager> form_manager) {
+ scoped_refptr<password_manager::PasswordFormManager> form_manager) {
ClearData();
form_manager_ = std::move(form_manager);
local_credentials_forms_ =
@@ -123,7 +123,7 @@ void ManagePasswordsState::OnAutoSignin(
}
void ManagePasswordsState::OnAutomaticPasswordSave(
- std::unique_ptr<PasswordFormManager> form_manager) {
+ scoped_refptr<PasswordFormManager> form_manager) {
ClearData();
form_manager_ = std::move(form_manager);
local_credentials_forms_.reserve(form_manager_->best_matches().size());
@@ -222,7 +222,7 @@ void ManagePasswordsState::ChooseCredential(
}
void ManagePasswordsState::ClearData() {
- form_manager_.reset();
+ form_manager_ = nullptr;
local_credentials_forms_.clear();
credentials_callback_.Reset();
}
« no previous file with comments | « chrome/browser/ui/passwords/manage_passwords_state.h ('k') | chrome/browser/ui/passwords/manage_passwords_state_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698