Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5503)

Unified Diff: chrome/browser/password_manager/save_password_infobar_delegate_android.h

Issue 2900693002: [Password Manager] Convert |pending_login_managers_| to an array of scoped_refptr (Closed)
Patch Set: Rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/save_password_infobar_delegate_android.h
diff --git a/chrome/browser/password_manager/save_password_infobar_delegate_android.h b/chrome/browser/password_manager/save_password_infobar_delegate_android.h
index f80501625b7e9cb5b2fb3072553b2e9a83364c52..c6c14030aa8fbf7c12eb77ecf2cb3c97e7ac2d36 100644
--- a/chrome/browser/password_manager/save_password_infobar_delegate_android.h
+++ b/chrome/browser/password_manager/save_password_infobar_delegate_android.h
@@ -8,6 +8,7 @@
#include <memory>
#include "base/macros.h"
+#include "base/memory/ref_counted.h"
#include "base/timer/elapsed_timer.h"
#include "chrome/browser/password_manager/password_manager_infobar_delegate_android.h"
#include "components/infobars/core/confirm_infobar_delegate.h"
@@ -32,7 +33,7 @@ class SavePasswordInfoBarDelegate : public PasswordManagerInfoBarDelegate {
// for |web_contents|.
static void Create(
content::WebContents* web_contents,
- std::unique_ptr<password_manager::PasswordFormManager> form_to_save);
+ scoped_refptr<password_manager::PasswordFormManager> form_to_save);
~SavePasswordInfoBarDelegate() override;
@@ -47,13 +48,13 @@ class SavePasswordInfoBarDelegate : public PasswordManagerInfoBarDelegate {
// Makes a ctor available in tests.
SavePasswordInfoBarDelegate(
content::WebContents* web_contents,
- std::unique_ptr<password_manager::PasswordFormManager> form_to_save,
+ scoped_refptr<password_manager::PasswordFormManager> form_to_save,
bool is_smartlock_branding_enabled);
private:
// The PasswordFormManager managing the form we're asking the user about,
// and should update as per their decision.
- std::unique_ptr<password_manager::PasswordFormManager> form_to_save_;
+ scoped_refptr<password_manager::PasswordFormManager> form_to_save_;
// Used to track the results we get from the info bar.
password_manager::metrics_util::UIDismissalReason infobar_response_;

Powered by Google App Engine
This is Rietveld 408576698