Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Unified Diff: net/nqe/network_quality_estimator_params.h

Issue 2899453002: Pass parsed network quality estimator params when constructing NQE (Closed)
Patch Set: Rebased Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/nqe/network_quality_estimator.cc ('k') | net/nqe/network_quality_estimator_params.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/nqe/network_quality_estimator_params.h
diff --git a/net/nqe/network_quality_estimator_params.h b/net/nqe/network_quality_estimator_params.h
index f543a54e41a275e20fcdea276783cffbf7e0115d..16d6bd44377ec5cbe13be3ff5dd35c71910c336f 100644
--- a/net/nqe/network_quality_estimator_params.h
+++ b/net/nqe/network_quality_estimator_params.h
@@ -22,13 +22,9 @@ namespace net {
// |params| provided to the NetworkQualityEstimatorParams constructor.
NET_EXPORT extern const char kForceEffectiveConnectionType[];
-namespace nqe {
-
-namespace internal {
-
// NetworkQualityEstimatorParams computes the configuration parameters for
// the network quality estimator.
-class NET_EXPORT_PRIVATE NetworkQualityEstimatorParams {
+class NET_EXPORT NetworkQualityEstimatorParams {
public:
// |params| is the map containing all field trial parameters related to
// NetworkQualityEstimator field trial.
@@ -50,15 +46,16 @@ class NET_EXPORT_PRIVATE NetworkQualityEstimatorParams {
// observations are different for different connection types (e.g., 2G, 3G,
// 4G, WiFi). The default observations may be used to determine the network
// quality in absence of any other information.
- const NetworkQuality& DefaultObservation(
+ const nqe::internal::NetworkQuality& DefaultObservation(
NetworkChangeNotifier::ConnectionType type) const;
// Returns the typical network quality for connection |type|.
- const NetworkQuality& TypicalNetworkQuality(
+ const nqe::internal::NetworkQuality& TypicalNetworkQuality(
EffectiveConnectionType type) const;
// Returns the threshold for effective connection type |type|.
- const NetworkQuality& ConnectionThreshold(EffectiveConnectionType type) const;
+ const nqe::internal::NetworkQuality& ConnectionThreshold(
+ EffectiveConnectionType type) const;
// Returns the minimum number of requests in-flight to consider the network
// fully utilized. A throughput observation is taken only when the network is
@@ -120,18 +117,18 @@ class NET_EXPORT_PRIVATE NetworkQualityEstimatorParams {
const base::TimeDelta min_socket_watcher_notification_interval_;
// Default network quality observations obtained from |params_|.
- NetworkQuality
+ nqe::internal::NetworkQuality
default_observations_[NetworkChangeNotifier::CONNECTION_LAST + 1];
// Typical network quality for different effective connection types obtained
// from |params_|.
- NetworkQuality typical_network_quality_
+ nqe::internal::NetworkQuality typical_network_quality_
[EffectiveConnectionType::EFFECTIVE_CONNECTION_TYPE_LAST];
// Thresholds for different effective connection types obtained from
// |params_|. These thresholds encode how different connection types behave
// in general.
- NetworkQuality connection_thresholds_
+ nqe::internal::NetworkQuality connection_thresholds_
[EffectiveConnectionType::EFFECTIVE_CONNECTION_TYPE_LAST];
base::ThreadChecker thread_checker_;
@@ -139,10 +136,6 @@ class NET_EXPORT_PRIVATE NetworkQualityEstimatorParams {
DISALLOW_COPY_AND_ASSIGN(NetworkQualityEstimatorParams);
};
-} // namespace internal
-
-} // namespace nqe
-
} // namespace net
#endif // NET_NQE_NETWORK_QUALITY_ESTIMATOR_PARAMS_H_
« no previous file with comments | « net/nqe/network_quality_estimator.cc ('k') | net/nqe/network_quality_estimator_params.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698