Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Unified Diff: chrome/browser/android/net/external_estimate_provider_android_unittest.cc

Issue 2899453002: Pass parsed network quality estimator params when constructing NQE (Closed)
Patch Set: Rebased Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/io_thread.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/net/external_estimate_provider_android_unittest.cc
diff --git a/chrome/browser/android/net/external_estimate_provider_android_unittest.cc b/chrome/browser/android/net/external_estimate_provider_android_unittest.cc
index eca05bbb849db7b780f8a8aa7ab79dcb31a9679b..46056bd08be1dc92d6521cf0b149d93079758ef4 100644
--- a/chrome/browser/android/net/external_estimate_provider_android_unittest.cc
+++ b/chrome/browser/android/net/external_estimate_provider_android_unittest.cc
@@ -8,11 +8,13 @@
#include <utility>
#include "base/at_exit.h"
+#include "base/memory/ptr_util.h"
#include "base/test/histogram_tester.h"
#include "base/time/time.h"
#include "content/public/test/test_browser_thread_bundle.h"
#include "net/log/test_net_log.h"
#include "net/nqe/network_quality_estimator.h"
+#include "net/nqe/network_quality_estimator_params.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace {
@@ -42,9 +44,11 @@ class TestNetworkQualityEstimator : public net::NetworkQualityEstimator {
external_estimate_provider,
const std::map<std::string, std::string>& variation_params,
net::NetLog* net_log)
- : NetworkQualityEstimator(std::move(external_estimate_provider),
- variation_params,
- net_log),
+ : NetworkQualityEstimator(
+ std::move(external_estimate_provider),
+ base::MakeUnique<net::NetworkQualityEstimatorParams>(
+ variation_params),
+ net_log),
notified_(false) {}
~TestNetworkQualityEstimator() override {}
« no previous file with comments | « no previous file | chrome/browser/io_thread.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698