Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1362)

Unified Diff: net/nqe/throughput_analyzer_unittest.cc

Issue 2899453002: Pass parsed network quality estimator params when constructing NQE (Closed)
Patch Set: fix Android compile error Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/nqe/throughput_analyzer.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/nqe/throughput_analyzer_unittest.cc
diff --git a/net/nqe/throughput_analyzer_unittest.cc b/net/nqe/throughput_analyzer_unittest.cc
index 4ed98ee2be0a3a299a646831eaeeb27e651b88d5..9d5020cf58a2a5cec74c7b7ea6f783487b5801ef 100644
--- a/net/nqe/throughput_analyzer_unittest.cc
+++ b/net/nqe/throughput_analyzer_unittest.cc
@@ -34,8 +34,7 @@ namespace {
class TestThroughputAnalyzer : public internal::ThroughputAnalyzer {
public:
- explicit TestThroughputAnalyzer(
- internal::NetworkQualityEstimatorParams* params)
+ explicit TestThroughputAnalyzer(NetworkQualityEstimatorParams* params)
: internal::ThroughputAnalyzer(
params,
base::ThreadTaskRunnerHandle::Get(),
@@ -85,7 +84,7 @@ TEST(ThroughputAnalyzerTest, MaximumRequests) {
for (const auto& test : tests) {
std::map<std::string, std::string> variation_params;
- internal::NetworkQualityEstimatorParams params(variation_params);
+ NetworkQualityEstimatorParams params(variation_params);
TestThroughputAnalyzer throughput_analyzer(&params);
TestDelegate test_delegate;
@@ -137,7 +136,7 @@ TEST(ThroughputAnalyzerTest, TestThroughputWithMultipleRequestsOverlap) {
for (const auto& test : tests) {
// Localhost requests are not allowed for estimation purposes.
std::map<std::string, std::string> variation_params;
- internal::NetworkQualityEstimatorParams params(variation_params);
+ NetworkQualityEstimatorParams params(variation_params);
TestThroughputAnalyzer throughput_analyzer(&params);
TestDelegate test_delegate;
@@ -226,7 +225,7 @@ TEST(ThroughputAnalyzerTest, TestThroughputWithNetworkRequestsOverlap) {
std::map<std::string, std::string> variation_params;
variation_params["throughput_min_requests_in_flight"] =
base::IntToString(test.throughput_min_requests_in_flight);
- internal::NetworkQualityEstimatorParams params(variation_params);
+ NetworkQualityEstimatorParams params(variation_params);
TestThroughputAnalyzer throughput_analyzer(&params);
TestDelegate test_delegate;
TestURLRequestContext context;
@@ -278,7 +277,7 @@ TEST(ThroughputAnalyzerTest, TestThroughputWithNetworkRequestsOverlap) {
TEST(ThroughputAnalyzerTest, TestThroughputWithMultipleNetworkRequests) {
std::map<std::string, std::string> variation_params;
variation_params["throughput_min_requests_in_flight"] = "3";
- internal::NetworkQualityEstimatorParams params(variation_params);
+ NetworkQualityEstimatorParams params(variation_params);
TestThroughputAnalyzer throughput_analyzer(&params);
TestDelegate test_delegate;
TestURLRequestContext context;
« no previous file with comments | « net/nqe/throughput_analyzer.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698