ReadDirectory() added in webrtc/test/testsupport/fileutils.h

webrtc/test/testsupport/fileutils.h

Index: webrtc/test/testsupport/fileutils.h
diff --git a/webrtc/test/testsupport/fileutils.h b/webrtc/test/testsupport/fileutils.h
index 2135681380c0fed1cd4510c640e20a9b9cf03f63..6677dbd8c115422729a35e273d45d08dc2b52728 100644
--- a/webrtc/test/testsupport/fileutils.h
+++ b/webrtc/test/testsupport/fileutils.h
@@ -14,6 +14,7 @@
 #define WEBRTC_TEST_TESTSUPPORT_FILEUTILS_H_
 
 #include <string>
+#include <vector>
 
 namespace webrtc {
 namespace test {
@@ -66,6 +67,12 @@ std::string ResourcePath(const std::string& name,
 // directory.
 std::string WorkingDir();
 
+// Reads the content of a directory, clears |output| and adds a string in it for
+// each found file or directory. Each entry is a path created by prepending
+// |dir| to the file/directory name. Returns true if no error occurs. "." and
+// ".." are never added in |output|.
+bool ReadDirectory(std::string path, std::vector<std::string>* output);

[kwiberg-webrtc, 2017/05/29 12:11:36]

Should the first argument be const std::string&? The function implementation
will not typically move from |path|, right?

Document the return value. Is it a success/fail boolean?

Consider returning Optional<vector<string>> instead of using an output argument,
since this is test code where clarity trumps performance.

[AleBzk, 2017/05/29 13:04:48]

Nope, I need a local copy to add a trailing / (or \) if missing.
Done.
Done.

[kwiberg-webrtc, 2017/05/30 08:28:12]

OK, that makes sense.

[AleBzk, 2017/05/30 11:09:16]

Acknowledged.

+
 // Creates a directory if it not already exists.
 // Returns true if successful. Will print an error message to stderr and return
 // false if a file with the same name already exists.