ReadDirectory() added in webrtc/test/testsupport/fileutils.h

webrtc/test/testsupport/fileutils.cc

Index: webrtc/test/testsupport/fileutils.cc
diff --git a/webrtc/test/testsupport/fileutils.cc b/webrtc/test/testsupport/fileutils.cc
index 02ef06580bbcec4203d46ac1c23f42d4e279ebd6..56e2f84a787542970880cb28f33b965c428b824f 100644
--- a/webrtc/test/testsupport/fileutils.cc
+++ b/webrtc/test/testsupport/fileutils.cc
@@ -24,6 +24,7 @@
 #include "webrtc/base/win32.h"
 #define GET_CURRENT_DIR _getcwd
 #else
+#include <dirent.h>
 #include <unistd.h>
 
 #define GET_CURRENT_DIR getcwd
@@ -40,6 +41,7 @@
 
 #include <memory>
 
+#include "webrtc/base/checks.h"
 #include "webrtc/typedefs.h"  // For architecture defines
 
 namespace webrtc {
@@ -126,7 +128,7 @@ std::string WorkingDir() {
   return kRootDirName;
 }
 
-#else // WEBRTC_ANDROID
+#else  // WEBRTC_ANDROID
 
 std::string ProjectRootPath() {
 #if defined(WEBRTC_IOS)
@@ -212,6 +214,48 @@ std::string TempFilename(const std::string &dir, const std::string &prefix) {
 #endif
 }
 
+bool ReadDirectory(std::string path, std::vector<std::string>* output) {
+  RTC_DCHECK(output);
+  if (path.length() == 0 || !DirExists(path)) return false;

[nisse-webrtc, 2017/05/29 10:56:39]

On second look, I think the DirExists check here is useless.
It should be sufficient to check for errors from FindFirstFile and opendir,
which we already do.

[AleBzk, 2017/05/29 11:09:29]

Done.

+  output->clear();

[nisse-webrtc, 2017/05/29 10:56:39]

The comment in the header file just says that strings are added to |output|. So
for consistency, either update the comment or delete this call to clear().

Another option is to change the return type to
rtc::Optional<std::vector<std::string>>. I'll leave that for your judgement.

[AleBzk, 2017/05/29 11:09:29]

Done.

+#if defined(WEBRTC_WIN)
+  // Append separator character if needed.
+  if (path.back() != '\\') path += '\\';
+
+  // Init.
+  WIN32_FIND_DATA data;
+  HANDLE handle = ::FindFirstFile(rtc::ToUtf16(path + '*').c_str(), &data);
+  if (handle == INVALID_HANDLE_VALUE) return false;
+
+  // Populate output.
+  do {
+    const std::string name = rtc::ToUtf8(data.cFileName);
+    if (name != "." && name != "..") output->emplace_back(path + name);
+  } while (::FindNextFile(handle, &data) == TRUE);
+
+  // Release resources.
+  if (handle != INVALID_HANDLE_VALUE) ::FindClose(handle);
+#else
+  // Append separator character if needed.
+  if (path.back() != '/') path += '/';
+
+  // Init.
+  DIR *dir = ::opendir(path.c_str());
+  if (dir == nullptr) return false;
+
+  // Populate output.
+  while (struct dirent* dirent = readdir(dir)) {
+    RTC_DCHECK(dirent);

[nisse-webrtc, 2017/05/29 10:56:39]

A DCHECK on the loop condition right above seems unnecessary. 

[AleBzk, 2017/05/29 11:09:29]

Done.

+    const std::string& name = dirent->d_name;
+    if (name != "." && name != "..") output->emplace_back(path + name);
+  }
+
+  // Release resources.
+  closedir(dir);
+#endif
+  return true;
+}
+
 bool CreateDir(const std::string& directory_name) {
   struct stat path_info = {0};
   // Check if the path exists already: