DescriptionPrevent previews from breaking offline pages.
Some of the optimizations enabled by previews work at cross purposes
with offline pages. Previews generally limit the downloaded page to
save bandwidth and load faster, where as for offline, the user generally
wants a fuller page to read when there is no connectivity.
The general strategy is to add a new parameter to the LoadURLParams to
disable previews, and if that parameter is set to disable the preview
functionality.
BUG=703875
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
This change was abandoned for a different approach
Patch Set 1 #Patch Set 2 : Improve Deps #Patch Set 3 : Second approach, not compiling yet. #
Total comments: 10
Patch Set 4 : New method for overriding previews_state flags #Patch Set 5 : Remove leftover comment #
Total comments: 4
Patch Set 6 : More CR feedback per RyanSturm #
Total comments: 1
Patch Set 7 : Allow Page Modifications approach (not yet passing presubmit checks) for discussion #Patch Set 8 : Alternative to not plumb APM (not passing presubmit checks) for discussion #Messages
Total messages: 23 (16 generated)
|