Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Unified Diff: webrtc/sdk/android/instrumentationtests/src/org/webrtc/EglRendererTest.java

Issue 2897043002: Allow FPS reduction to be applied to frame listeners. (Closed)
Patch Set: Changes according to magjed's comments. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/sdk/android/api/org/webrtc/EglRenderer.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/sdk/android/instrumentationtests/src/org/webrtc/EglRendererTest.java
diff --git a/webrtc/sdk/android/instrumentationtests/src/org/webrtc/EglRendererTest.java b/webrtc/sdk/android/instrumentationtests/src/org/webrtc/EglRendererTest.java
index e74ec93c728b87e199694464fe327619a55dea4f..49c7dd33cef36325a8a10deec8a5eb13425bc45a 100644
--- a/webrtc/sdk/android/instrumentationtests/src/org/webrtc/EglRendererTest.java
+++ b/webrtc/sdk/android/instrumentationtests/src/org/webrtc/EglRendererTest.java
@@ -310,12 +310,29 @@ public class EglRendererTest {
@Test
@SmallTest
- public void testFrameListenersWhilePaused() throws Exception {
- // Test that frame listeners receive frames while renderer is paused.
+ public void testFrameListenersFpsReduction() throws Exception {
+ // Test that normal frame listeners receive frames while the renderer is paused.
eglRenderer.pauseVideo();
eglRenderer.addFrameListener(testFrameListener, 1f /* scaleFactor */);
feedFrame(0);
assertTrue(testFrameListener.waitForBitmap(RENDER_WAIT_MS));
checkBitmapContent(testFrameListener.resetAndGetBitmap(), 0);
+
+ // Test that frame listeners with FPS reduction applied receive frames while the renderer is not
+ // paused.
+ eglRenderer.disableFpsReduction();
+ eglRenderer.addFrameListener(
+ testFrameListener, 1f /* scaleFactor */, null, true /* applyFpsReduction */);
+ feedFrame(1);
+ assertTrue(testFrameListener.waitForBitmap(RENDER_WAIT_MS));
+ checkBitmapContent(testFrameListener.resetAndGetBitmap(), 1);
+
+ // Test that frame listeners with FPS reduction applied will not receive frames while the
+ // renderer is paused.
+ eglRenderer.pauseVideo();
+ eglRenderer.addFrameListener(
+ testFrameListener, 1f /* scaleFactor */, null, true /* applyFpsReduction */);
+ feedFrame(1);
+ assertFalse(testFrameListener.waitForBitmap(RENDER_WAIT_MS));
}
}
« no previous file with comments | « webrtc/sdk/android/api/org/webrtc/EglRenderer.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698