Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 2897033006: [Mojo Video Capture] Initialize COM on Windows (Closed)

Created:
3 years, 7 months ago by chfremer
Modified:
3 years, 7 months ago
Reviewers:
jam
CC:
chromium-reviews, posciak+watch_chromium.org, chfremer+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mojo Video Capture] Initialize COM on Windows This CL is part of the Mojo Video Capture work. For the bigger picture, see [1] CL25_enable_win. * Added a ScopedCOMInitializer to ServiceImpl in order to initialize COM on the service main thread, which is also the thread that interacts with the video capture devices. BUG=584797 TEST= content_browsertests --gtest_filter="VideoCaptureBrowserTest.*" [1] https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxsxWslJ_X-zpOhijvI8/edit?usp=sharing Review-Url: https://codereview.chromium.org/2897033006 Cr-Commit-Position: refs/heads/master@{#474876} Committed: https://chromium.googlesource.com/chromium/src/+/48b7318b1de86b6c40fb6a18e45a8f330f641ba9

Patch Set 1 #

Patch Set 2 : Move the |com_initializer_| to top of members #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M services/video_capture/service_impl.h View 1 2 chunks +8 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (9 generated)
chfremer
PTAL
3 years, 7 months ago (2017-05-23 23:54:03 UTC) #3
jam
lgtm
3 years, 7 months ago (2017-05-24 15:10:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2897033006/20001
3 years, 7 months ago (2017-05-25 21:49:59 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-26 02:01:31 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/48b7318b1de86b6c40fb6a18e45a...

Powered by Google App Engine
This is Rietveld 408576698