cros: Pull TestLockScreenClient into a separate MockLockScreenClient file.

cros: Pull TestLockScreenClient into a separate MockLockScreenClient file.

- converted the class to a mock.
- made it easy for tests to create an instance by defining a helper method.

BUG=719015
Review-Url: https://codereview.chromium.org/2894193002
Cr-Commit-Position: refs/heads/master@{#475135}
Committed: https://chromium.googlesource.com/chromium/src/+/87469729cfc60bc4cc139dc55b2410bda8f65e5f

[jdufault, 2017-05-19 18:32:51]

The CQ bit was checked by jdufault@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-19 18:34:21]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jdufault, 2017-05-19 19:07:26]

The CQ bit was checked by jdufault@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-19 19:08:48]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 20:15:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 20:15:12]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jdufault, 2017-05-22 23:14:07]

The CQ bit was checked by jdufault@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-22 23:15:01]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 00:41:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-23 00:41:23]

Dry run: This issue passed the CQ dry run.

[jdufault, 2017-05-23 19:05:57]

Description was changed from

==========
cros: Pull TestLockScreenClient into a separate MockLockScreenClient file.

- converted the class to a mock.
- made it easy for tests to create an instance by defining a helper method.

BUG=
==========

to

==========
cros: Pull TestLockScreenClient into a separate MockLockScreenClient file.

- converted the class to a mock.
- made it easy for tests to create an instance by defining a helper method.

BUG=719015
==========

[jdufault, 2017-05-23 19:06:17]

Patchset #2 (id:20001) has been deleted

[jdufault, 2017-05-23 19:06:27]

Patchset #1 (id:1) has been deleted

[jdufault, 2017-05-24 19:20:59]

jdufault@chromium.org changed reviewers:
+ xiaoyinh@chromium.org, xiyuan@chromium.org

[jdufault, 2017-05-24 19:21:22]

xiaoyinh@, xiyuan@, PTAL

[xiyuan, 2017-05-24 20:58:43]

lgtm

https://codereview.chromium.org/2894193002/diff/40001/ash/login/lock_screen_c...
File ash/login/lock_screen_controller_unittest.cc (right):

https://codereview.chromium.org/2894193002/diff/40001/ash/login/lock_screen_c...
ash/login/lock_screen_controller_unittest.cc:29: std::string password =
"password";
nit: const std::string

[xiaoyinh(OOO Sep 11-29), 2017-05-24 22:15:20]

lgtm.

[jdufault, 2017-05-26 17:51:31]

The CQ bit was checked by jdufault@chromium.org

[jdufault, 2017-05-26 17:51:31]

The patchset sent to the CQ was uploaded after l-g-t-m from xiyuan@chromium.org,
xiaoyinh@chromium.org
Link to the patchset: https://codereview.chromium.org/2894193002/#ps60001
(title: "Rebase (remove parent dep)")

[commit-bot: I haz the power, 2017-05-26 17:51:52]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 19:27:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-26 19:27:24]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jdufault, 2017-05-26 19:53:14]

The CQ bit was checked by jdufault@chromium.org

[commit-bot: I haz the power, 2017-05-26 19:53:41]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 21:26:04]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1495828394438630,
"parent_rev": "793a817301622f653c43ec9ad8869b4b1e373b0a", "commit_rev":
"87469729cfc60bc4cc139dc55b2410bda8f65e5f"}

[commit-bot: I haz the power, 2017-05-26 21:27:09]

Description was changed from

==========
cros: Pull TestLockScreenClient into a separate MockLockScreenClient file.

- converted the class to a mock.
- made it easy for tests to create an instance by defining a helper method.

BUG=719015
==========

to

==========
cros: Pull TestLockScreenClient into a separate MockLockScreenClient file.

- converted the class to a mock.
- made it easy for tests to create an instance by defining a helper method.

BUG=719015

Review-Url: https://codereview.chromium.org/2894193002
Cr-Commit-Position: refs/heads/master@{#475135}
Committed:
https://chromium.googlesource.com/chromium/src/+/87469729cfc60bc4cc139dc55b24...
==========

[commit-bot: I haz the power, 2017-05-26 21:27:11]

Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/87469729cfc60bc4cc139dc55b24...