Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 2894193002: cros: Pull TestLockScreenClient into a separate MockLockScreenClient file. (Closed)

Created:
3 years, 7 months ago by jdufault
Modified:
3 years, 6 months ago
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

cros: Pull TestLockScreenClient into a separate MockLockScreenClient file. - converted the class to a mock. - made it easy for tests to create an instance by defining a helper method. BUG=719015 Review-Url: https://codereview.chromium.org/2894193002 Cr-Commit-Position: refs/heads/master@{#475135} Committed: https://chromium.googlesource.com/chromium/src/+/87469729cfc60bc4cc139dc55b2410bda8f65e5f

Patch Set 1 : Initial upload #

Total comments: 1

Patch Set 2 : Rebase (remove parent dep) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -38 lines) Patch
M ash/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
M ash/login/lock_screen_controller_unittest.cc View 1 chunk +18 lines, -38 lines 0 comments Download
A ash/login/mock_lock_screen_client.h View 1 chunk +38 lines, -0 lines 0 comments Download
A ash/login/mock_lock_screen_client.cc View 1 chunk +29 lines, -0 lines 0 comments Download

Messages

Total messages: 27 (20 generated)
jdufault
xiaoyinh@, xiyuan@, PTAL
3 years, 7 months ago (2017-05-24 19:21:22 UTC) #15
xiyuan
lgtm https://codereview.chromium.org/2894193002/diff/40001/ash/login/lock_screen_controller_unittest.cc File ash/login/lock_screen_controller_unittest.cc (right): https://codereview.chromium.org/2894193002/diff/40001/ash/login/lock_screen_controller_unittest.cc#newcode29 ash/login/lock_screen_controller_unittest.cc:29: std::string password = "password"; nit: const std::string
3 years, 7 months ago (2017-05-24 20:58:43 UTC) #16
xiaoyinh(OOO Sep 11-29)
lgtm.
3 years, 7 months ago (2017-05-24 22:15:20 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2894193002/60001
3 years, 6 months ago (2017-05-26 17:51:52 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/380280)
3 years, 6 months ago (2017-05-26 19:27:24 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2894193002/60001
3 years, 6 months ago (2017-05-26 19:53:41 UTC) #24
commit-bot: I haz the power
3 years, 6 months ago (2017-05-26 21:27:11 UTC) #27
Message was sent while issue was closed.
Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/87469729cfc60bc4cc139dc55b24...

Powered by Google App Engine
This is Rietveld 408576698