Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5588)

Unified Diff: chrome/browser/extensions/api/feedback_private/feedback_private_api.cc

Issue 2891923006: Add the status of ARC to the Feedback PSDs. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/feedback/system_logs/log_sources/chrome_internal_log_source.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/feedback_private/feedback_private_api.cc
diff --git a/chrome/browser/extensions/api/feedback_private/feedback_private_api.cc b/chrome/browser/extensions/api/feedback_private/feedback_private_api.cc
index 9ed38eb170851e07a154349611e177c225d2927d..b13cf765fee1e86d05d99ee2bb3f87d5ef7e24a0 100644
--- a/chrome/browser/extensions/api/feedback_private/feedback_private_api.cc
+++ b/chrome/browser/extensions/api/feedback_private/feedback_private_api.cc
@@ -295,13 +295,14 @@ bool FeedbackPrivateSendFeedbackFunction::RunAsync() {
feedback_data->set_screenshot_uuid(*feedback_info.screenshot_blob_uuid);
}
- std::unique_ptr<FeedbackData::SystemLogsMap> sys_logs(
- new FeedbackData::SystemLogsMap);
- SystemInformationList* sys_info = feedback_info.system_information.get();
+ auto sys_logs = base::MakeUnique<FeedbackData::SystemLogsMap>();
+ const SystemInformationList* sys_info =
+ feedback_info.system_information.get();
if (sys_info) {
for (const SystemInformation& info : *sys_info)
- (*sys_logs)[info.key] = info.value;
+ sys_logs->emplace(info.key, info.value);
}
+
feedback_data->SetAndCompressSystemInfo(std::move(sys_logs));
FeedbackService* service =
@@ -309,7 +310,7 @@ bool FeedbackPrivateSendFeedbackFunction::RunAsync() {
DCHECK(service);
if (feedback_info.send_histograms) {
- std::unique_ptr<std::string> histograms(new std::string);
+ auto histograms = base::MakeUnique<std::string>();
*histograms = base::StatisticsRecorder::ToJSON(std::string());
if (!histograms->empty())
feedback_data->SetAndCompressHistograms(std::move(histograms));
« no previous file with comments | « no previous file | chrome/browser/feedback/system_logs/log_sources/chrome_internal_log_source.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698