webrtc/sdk/android/src/jni/DEPS - Issue 2891803003: Add vp9 QP parser.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: webrtc/sdk/android/src/jni/DEPS

Issue 2891803003: Add vp9 QP parser. (Closed)

Patch Set: Fix compile warnings. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« webrtc/modules/video_coding/utility/vp9_uncomp_header_parser.cc ('K') | « webrtc/modules/video_coding/utility/vp9_uncomp_header_parser.cc ('k') | webrtc/sdk/android/src/jni/androidmediadecoder_jni.cc » ('j') | webrtc/video/video_loopback.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 include_rules = [	1 include_rules = [

2 "+third_party/libyuv",	2 "+third_party/libyuv",

3 "+webrtc/common_video/h264/h264_bitstream_parser.h",	3 "+webrtc/common_video/h264/h264_bitstream_parser.h",

4 "+webrtc/common_video/libyuv/include/webrtc_libyuv.h",	4 "+webrtc/common_video/libyuv/include/webrtc_libyuv.h",

5 "+webrtc/modules/utility/include/jvm_android.h",	5 "+webrtc/modules/utility/include/jvm_android.h",

6 "+webrtc/modules/video_coding/utility/vp8_header_parser.h",	6 "+webrtc/modules/video_coding/utility/vp8_header_parser.h",

	7 "+webrtc/modules/video_coding/utility/vp9_uncomp_header_parser.h",
	brandtr 2017/05/19 14:10:27 To reduce the number of OWNERs required, you can r To reduce the number of OWNERs required, you can remove the changes to the android/ files. Adding the header can then be done when support is actually added to the Android encoder implementation. jianj1 2017/05/19 21:20:57 I'm not quite clear about this, though I removed t Show quoted text On 2017/05/19 14:10:27, brandtr wrote: > To reduce the number of OWNERs required, you can remove the changes to the > android/ files. Adding the header can then be done when support is actually > added to the Android encoder implementation. I'm not quite clear about this, though I removed this rule currently. Is the qp parser also used in other platforms besides android? brandtr 2017/05/22 18:34:56 No, it will only be used by Android. But since thi Show quoted text On 2017/05/19 21:20:57, jianj1 wrote: > On 2017/05/19 14:10:27, brandtr wrote: > > To reduce the number of OWNERs required, you can remove the changes to the > > android/ files. Adding the header can then be done when support is actually > > added to the Android encoder implementation. > > I'm not quite clear about this, though I removed this rule currently. Is the qp > parser also used in other platforms besides android? No, it will only be used by Android. But since this CL does not add it to Android, you will require fewer OWNER approvals by not changing anything outside the video_coding/ folder :)
7 "+webrtc/pc",	8 "+webrtc/pc",

8 "+webrtc/system_wrappers/include/field_trial_default.h",	9 "+webrtc/system_wrappers/include/field_trial_default.h",

9 ]	10 ]

OLD	NEW