webrtc/pc/channel_unittest.cc - Issue 2890263003: Move RTP/RTCP demuxing logic from BaseChannel to RtpTransport.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/pc/channel_unittest.cc

Issue 2890263003: Move RTP/RTCP demuxing logic from BaseChannel to RtpTransport. (Closed)

Patch Set: Disconnect transport channels in method called from Deinit to prevent races during object destructi… Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/pc/channel_unittest.cc

diff --git a/webrtc/pc/channel_unittest.cc b/webrtc/pc/channel_unittest.cc

index 6c4aa0f9ceb789a7ea1829150320b9c53e258cda..a351e17dfc31a474c34e91223869e865950c7399 100644

--- a/webrtc/pc/channel_unittest.cc

+++ b/webrtc/pc/channel_unittest.cc

@@ -1560,10 +1560,10 @@ class ChannelTest : public testing::Test, public sigslot::has_slots<> {

EXPECT_TRUE(SendAccept());

EXPECT_EQ(rtcp_mux, !channel1_->NeedsRtcpTransport());

EXPECT_EQ(rtcp_mux, !channel2_->NeedsRtcpTransport());

- EXPECT_TRUE(channel1_->bundle_filter()->FindPayloadType(pl_type1));

- EXPECT_TRUE(channel2_->bundle_filter()->FindPayloadType(pl_type1));

- EXPECT_FALSE(channel1_->bundle_filter()->FindPayloadType(pl_type2));

- EXPECT_FALSE(channel2_->bundle_filter()->FindPayloadType(pl_type2));

+ EXPECT_TRUE(channel1_->HandlesPayloadType(pl_type1));

+ EXPECT_TRUE(channel2_->HandlesPayloadType(pl_type1));

+ EXPECT_FALSE(channel1_->HandlesPayloadType(pl_type2));

+ EXPECT_FALSE(channel2_->HandlesPayloadType(pl_type2));

// Both channels can receive pl_type1 only.

SendCustomRtp1(kSsrc1, ++sequence_number1_1, pl_type1);

« no previous file with comments | « webrtc/pc/channel.cc ('k') | webrtc/pc/rtcpmuxfilter.h » ('j') | no next file with comments »