webrtc/system_wrappers/include/static_instance.h - Issue 2890213002: Prevent data race in GetStaticInstance

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/system_wrappers/include/static_instance.h

Issue 2890213002: Prevent data race in GetStaticInstance (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/system_wrappers/include/static_instance.h

diff --git a/webrtc/system_wrappers/include/static_instance.h b/webrtc/system_wrappers/include/static_instance.h

index e9bf81d951ebec749aca5a7d8dc303bbf6b06d84..ad87fe68299ee051f95d9e200a0a0b867a530b4f 100644

--- a/webrtc/system_wrappers/include/static_instance.h

+++ b/webrtc/system_wrappers/include/static_instance.h

@@ -40,7 +40,7 @@ static T* GetStaticInstance(CountOperation count_operation) {

static T* volatile instance = NULL;

CreateOperation state = kInstanceExists;

#ifndef _WIN32

- rtc::CriticalSection crit_sect;

+ static rtc::CriticalSection crit_sect;

rtc::CritScope lock(&crit_sect);

if (count_operation ==

« no previous file with comments | « no previous file | no next file » | no next file with comments »