Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.cc

Issue 2889993004: New CPAT support in DataReductionProxyConfig guarded by feature flag. (Closed)
Patch Set: Updates new code path to accept LoFi when LitePages enabled (to allow fallback) Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.cc
diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.cc
index f356c698c77d64acd8d6e60c51fea27b3911c68c..90318bc3eea80ccc4e82de9a2132555d6ff7839c 100644
--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.cc
+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.cc
@@ -293,23 +293,25 @@ void DataReductionProxyIOData::SetDataReductionProxyConfiguration(
bool DataReductionProxyIOData::ShouldEnableLoFi(
const net::URLRequest& request,
previews::PreviewsDecider* previews_decider) {
+ DCHECK(previews_decider);
DCHECK((request.load_flags() & net::LOAD_MAIN_FRAME_DEPRECATED) != 0);
if (!config_ || (config_->IsBypassedByDataReductionProxyLocalRules(
request, configurator_->GetProxyConfig()))) {
return false;
}
- return config_->ShouldEnableLoFi(request, previews_decider);
+ return config_->ShouldEnableLoFi(request, *previews_decider);
}
bool DataReductionProxyIOData::ShouldEnableLitePages(
const net::URLRequest& request,
previews::PreviewsDecider* previews_decider) {
+ DCHECK(previews_decider);
DCHECK((request.load_flags() & net::LOAD_MAIN_FRAME_DEPRECATED) != 0);
if (!config_ || (config_->IsBypassedByDataReductionProxyLocalRules(
request, configurator_->GetProxyConfig()))) {
return false;
}
- return config_->ShouldEnableLitePages(request, previews_decider);
+ return config_->ShouldEnableLitePages(request, *previews_decider);
}
void DataReductionProxyIOData::SetLoFiModeOff() {

Powered by Google App Engine
This is Rietveld 408576698