Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2888893002: Renaming probing_interval to bwe_period globally. (Closed)

Created:
3 years, 7 months ago by minyue-webrtc
Modified:
3 years, 7 months ago
CC:
webrtc-reviews_webrtc.org, zhuangzesen_agora.io, stefan-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, kwiberg-webrtc, the sun, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Renaming probing_interval to bwe_period globally. probing_interval as a name is used for the period that BWE attempt to increase its estimate. The name is confusing since it is not related to "probing" which is a special mechanism for estimating BWE. BUG=None Review-Url: https://codereview.webrtc.org/2888893002 Cr-Commit-Position: refs/heads/master@{#18203} Committed: https://chromium.googlesource.com/external/webrtc/+/93e4522105e9933202d660f20a1d86f0c4972a40

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -20 lines) Patch
M webrtc/api/audio_codecs/audio_encoder.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/api/audio_codecs/audio_encoder.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/audio/audio_send_stream.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/audio/audio_send_stream.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/call/bitrate_allocator.h View 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/call/bitrate_allocator.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/aimd_rate_control.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M webrtc/test/fuzzers/congestion_controller_feedback_fuzzer.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 21 (10 generated)
minyue-webrtc
Björn did some update before and it is generally confusing to use probing interval since ...
3 years, 7 months ago (2017-05-17 10:04:10 UTC) #3
terelius
lgmt
3 years, 7 months ago (2017-05-17 10:09:02 UTC) #5
terelius
lgtm
3 years, 7 months ago (2017-05-17 10:09:21 UTC) #6
michaelt
lgtm
3 years, 7 months ago (2017-05-17 11:13:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2888893002/1
3 years, 7 months ago (2017-05-17 11:19:51 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/17117)
3 years, 7 months ago (2017-05-17 11:24:22 UTC) #11
minyue-webrtc
On 2017/05/17 11:24:22, commit-bot: I haz the power wrote: > Try jobs failed on following ...
3 years, 7 months ago (2017-05-17 11:43:33 UTC) #13
minyue-webrtc
+Karl for missing owner's approval since Fredrik is OOO
3 years, 7 months ago (2017-05-18 13:53:42 UTC) #15
kwiberg-webrtc
lgtm
3 years, 7 months ago (2017-05-18 20:19:04 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2888893002/1
3 years, 7 months ago (2017-05-18 20:30:30 UTC) #18
commit-bot: I haz the power
3 years, 7 months ago (2017-05-18 21:32:48 UTC) #21
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/93e4522105e9933202d660f20...

Powered by Google App Engine
This is Rietveld 408576698