Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2426)

Unified Diff: webrtc/api/peerconnectioninterface.h

Issue 2888303005: Add PeerConnectionInterface::UpdateCallBitrate. (Closed)
Patch Set: Add a missing test from Taylor's last CR. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/api/peerconnectionproxy.h » ('j') | webrtc/call/call.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/api/peerconnectioninterface.h
diff --git a/webrtc/api/peerconnectioninterface.h b/webrtc/api/peerconnectioninterface.h
index 8c5a64bf1ebf69d197ac61d55c1731e95bdf7699..8bfd4d28284db2c0339362bb868e2929664103cf 100644
--- a/webrtc/api/peerconnectioninterface.h
+++ b/webrtc/api/peerconnectioninterface.h
@@ -729,6 +729,21 @@ class PeerConnectionInterface : public rtc::RefCountInterface {
// destroyed, RegisterUMAOberver(nullptr) should be called.
virtual void RegisterUMAObserver(UMAObserver* observer) = 0;
+ // 0 <= min <= current <= max should hold for set parameters.
kwiberg-webrtc 2017/05/24 08:27:55 Are all 8 combinations of set/unset supported?
Zach Stein 2017/05/24 21:10:02 Yes.
+ struct BitrateParameters {
+ rtc::Optional<int> min_bitrate_bps;
+ rtc::Optional<int> current_bitrate_bps;
+ rtc::Optional<int> max_bitrate_bps;
+ };
+
+ // SetBitrate limits the bandwidth allocated for all RTP streams sent by
+ // this PeerConnection. Other limitations might affect these limits and
+ // are respected (for example "b=AS" in SDP).
+ //
+ // Changing |current_bitrate_bps| to a new value will reset the current
Taylor Brandstetter 2017/05/25 15:33:52 This comment may need to be updated. It's not just
Zach Stein 2017/05/25 20:26:31 Done.
+ // bitrate estimate to the provided value.
+ virtual RTCError SetBitrate(const BitrateParameters& bitrate) = 0;
+
// Returns the current SignalingState.
virtual SignalingState signaling_state() = 0;
virtual IceConnectionState ice_connection_state() = 0;
« no previous file with comments | « no previous file | webrtc/api/peerconnectionproxy.h » ('j') | webrtc/call/call.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698