Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1836)

Unified Diff: webrtc/modules/rtp_rtcp/source/ulpfec_receiver_impl.cc

Issue 2886813002: Delete RtpData::OnRecoveredPacket, use RecoveredPacketReceiver instead. (Closed)
Patch Set: Comment nit. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/rtp_rtcp/source/ulpfec_receiver_impl.cc
diff --git a/webrtc/modules/rtp_rtcp/source/ulpfec_receiver_impl.cc b/webrtc/modules/rtp_rtcp/source/ulpfec_receiver_impl.cc
index 2752a378c9fa8fed18486905a38e367083b31335..dad445dab0e45cd78af7086b7a0f44727e7cc979 100644
--- a/webrtc/modules/rtp_rtcp/source/ulpfec_receiver_impl.cc
+++ b/webrtc/modules/rtp_rtcp/source/ulpfec_receiver_impl.cc
@@ -21,11 +21,11 @@
namespace webrtc {
-UlpfecReceiver* UlpfecReceiver::Create(RtpData* callback) {
+UlpfecReceiver* UlpfecReceiver::Create(RecoveredPacketReceiver* callback) {
return new UlpfecReceiverImpl(callback);
}
-UlpfecReceiverImpl::UlpfecReceiverImpl(RtpData* callback)
+UlpfecReceiverImpl::UlpfecReceiverImpl(RecoveredPacketReceiver* callback)
: recovered_packet_callback_(callback),
fec_(ForwardErrorCorrection::CreateUlpfec()) {}
@@ -212,10 +212,8 @@ int32_t UlpfecReceiverImpl::ProcessReceivedFec() {
if (!received_packets_.front()->is_fec) {
ForwardErrorCorrection::Packet* packet = received_packets_.front()->pkt;
crit_sect_.Leave();
- if (!recovered_packet_callback_->OnRecoveredPacket(packet->data,
- packet->length)) {
- return -1;
- }
+ recovered_packet_callback_->OnRecoveredPacket(packet->data,
+ packet->length);
crit_sect_.Enter();
}
if (fec_->DecodeFec(&received_packets_, &recovered_packets_) != 0) {
@@ -233,10 +231,8 @@ int32_t UlpfecReceiverImpl::ProcessReceivedFec() {
ForwardErrorCorrection::Packet* packet = recovered_packet->pkt;
++packet_counter_.num_recovered_packets;
crit_sect_.Leave();
- if (!recovered_packet_callback_->OnRecoveredPacket(packet->data,
- packet->length)) {
- return -1;
- }
+ recovered_packet_callback_->OnRecoveredPacket(packet->data,
+ packet->length);
crit_sect_.Enter();
recovered_packet->returned = true;
}
« no previous file with comments | « webrtc/modules/rtp_rtcp/source/ulpfec_receiver_impl.h ('k') | webrtc/modules/rtp_rtcp/source/ulpfec_receiver_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698