Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Unified Diff: webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h

Issue 2886813002: Delete RtpData::OnRecoveredPacket, use RecoveredPacketReceiver instead. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h
diff --git a/webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h b/webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h
index 11bc9433a45709dd73255d0d0f3c64766488a613..6ee2f998ce0e06648bc7b855a1e52fa9ed8df083 100644
--- a/webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h
+++ b/webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h
@@ -195,9 +195,17 @@ class RtpData {
virtual int32_t OnReceivedPayloadData(const uint8_t* payload_data,
size_t payload_size,
const WebRtcRTPHeader* rtp_header) = 0;
+};
+
+// Callback interface for packets recovered by FlexFEC. The implementation
danilchap 2017/05/16 18:06:43 since it is not used just by flexfec, update the c
+// should be able to demultiplex the recovered RTP packets based on SSRC.
+// TODO(nisse): Also used for ulpfec, is that usage different?
+class RecoveredPacketReceiver {
+ public:
+ virtual void OnRecoveredPacket(const uint8_t* packet, size_t length) = 0;
- virtual bool OnRecoveredPacket(const uint8_t* packet,
- size_t packet_length) = 0;
+ protected:
+ virtual ~RecoveredPacketReceiver() = default;
};
class RtpFeedback {
@@ -400,10 +408,6 @@ class NullRtpData : public RtpData {
const WebRtcRTPHeader* rtp_header) override {
return 0;
}
-
- bool OnRecoveredPacket(const uint8_t* packet, size_t packet_length) override {
- return true;
- }
};
// Statistics about packet loss for a single directional connection. All values

Powered by Google App Engine
This is Rietveld 408576698