Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: webrtc/modules/rtp_rtcp/source/rtp_receiver_impl.cc

Issue 2885823002: Delete class NullRtpData and function NullObjectRtpData (Closed)
Patch Set: Undo added includes, no longer needed after rebase. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtcp_sender_unittest.cc ('k') | webrtc/modules/rtp_rtcp/source/rtp_receiver_unittest.cc » ('j') | webrtc/modules/rtp_rtcp/source/rtp_receiver_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/rtp_rtcp/source/rtp_receiver_impl.cc
diff --git a/webrtc/modules/rtp_rtcp/source/rtp_receiver_impl.cc b/webrtc/modules/rtp_rtcp/source/rtp_receiver_impl.cc
index 2c19298948b04cd92dbb0e24d431fb424c9aafbb..01ccd2b26080bced1eed1cd007fdd36681b34a50 100644
--- a/webrtc/modules/rtp_rtcp/source/rtp_receiver_impl.cc
+++ b/webrtc/modules/rtp_rtcp/source/rtp_receiver_impl.cc
@@ -36,8 +36,7 @@ RtpReceiver* RtpReceiver::CreateVideoReceiver(
RtpData* incoming_payload_callback,
RtpFeedback* incoming_messages_callback,
RTPPayloadRegistry* rtp_payload_registry) {
- if (!incoming_payload_callback)
- incoming_payload_callback = NullObjectRtpData();
+ RTC_DCHECK(incoming_payload_callback != nullptr);
if (!incoming_messages_callback)
incoming_messages_callback = NullObjectRtpFeedback();
return new RtpReceiverImpl(
@@ -50,8 +49,7 @@ RtpReceiver* RtpReceiver::CreateAudioReceiver(
RtpData* incoming_payload_callback,
RtpFeedback* incoming_messages_callback,
RTPPayloadRegistry* rtp_payload_registry) {
- if (!incoming_payload_callback)
- incoming_payload_callback = NullObjectRtpData();
+ RTC_DCHECK(incoming_payload_callback != nullptr);
if (!incoming_messages_callback)
incoming_messages_callback = NullObjectRtpFeedback();
return new RtpReceiverImpl(
« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtcp_sender_unittest.cc ('k') | webrtc/modules/rtp_rtcp/source/rtp_receiver_unittest.cc » ('j') | webrtc/modules/rtp_rtcp/source/rtp_receiver_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698