webrtc/base/asyncinvoker.h - Issue 2885143006: Fixing potential AsyncInvoker deadlock that occurs for "reentrant" invocations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/base/asyncinvoker.h

Issue 2885143006: Fixing potential AsyncInvoker deadlock that occurs for "reentrant" invocations. (Closed)

Patch Set: Addressing TSan race warning Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/base/asyncinvoker.h

diff --git a/webrtc/base/asyncinvoker.h b/webrtc/base/asyncinvoker.h

index 541486741841b82b09b936cf6aceb65d56f4872a..0684f4cfee517d46f3590212340d0cc86af6986b 100644

--- a/webrtc/base/asyncinvoker.h

+++ b/webrtc/base/asyncinvoker.h

@@ -120,7 +120,7 @@ class AsyncInvoker : public MessageHandler {

uint32_t id);

volatile int pending_invocations_ = 0;

Event invocation_complete_;

- bool destroying_ = false;

+ int destroying_ = 0;

friend class AsyncClosure;

RTC_DISALLOW_COPY_AND_ASSIGN(AsyncInvoker);

« no previous file with comments | « no previous file | webrtc/base/asyncinvoker.cc » ('j') | no next file with comments »