webrtc/base/asyncinvoker-inl.h - Issue 2885143006: Fixing potential AsyncInvoker deadlock that occurs for "reentrant" invocations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/base/asyncinvoker-inl.h

Issue 2885143006: Fixing potential AsyncInvoker deadlock that occurs for "reentrant" invocations. (Closed)

Patch Set: Addressing TSan race warning Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/base/asyncinvoker-inl.h

diff --git a/webrtc/base/asyncinvoker-inl.h b/webrtc/base/asyncinvoker-inl.h

index 5f7cd4959a07e695ee9d526b31f641240aa33862..a1c2c8e0cf6591f6c80a0dc0b480f483be39de1f 100644

--- a/webrtc/base/asyncinvoker-inl.h

+++ b/webrtc/base/asyncinvoker-inl.h

@@ -27,7 +27,7 @@ class AsyncInvoker;

// on the calling thread if necessary.

class AsyncClosure {

public:

- explicit AsyncClosure(AsyncInvoker* invoker) : invoker_(invoker) {}

+ explicit AsyncClosure(AsyncInvoker* invoker);

virtual ~AsyncClosure();

// Runs the asynchronous task, and triggers a callback to the calling

// thread if needed. Should be called from the target thread.

« no previous file with comments | « webrtc/base/asyncinvoker.cc ('k') | webrtc/base/thread_unittest.cc » ('j') | no next file with comments »