third_party/WebKit/Source/core/page/scrolling/OverscrollController.cpp - Issue 2884423003: Use scroll-boundary-behavior to control overscroll-refresh/glow on android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/scrolling/OverscrollController.cpp

Issue 2884423003: Use scroll-boundary-behavior to control overscroll-refresh/glow on android. (Closed)

Patch Set: Rebase Created 3 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/page/scrolling/OverscrollController.h ('k') | third_party/WebKit/Source/core/page/scrolling/RootScrollerTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/page/scrolling/OverscrollController.cpp

diff --git a/third_party/WebKit/Source/core/page/scrolling/OverscrollController.cpp b/third_party/WebKit/Source/core/page/scrolling/OverscrollController.cpp

index 696be5612a2cafbcd404a57036ab132e39c723a6..86acaa53d9b883d3e569ef46d92ab0fe2eb55efb 100644

--- a/third_party/WebKit/Source/core/page/scrolling/OverscrollController.cpp

+++ b/third_party/WebKit/Source/core/page/scrolling/OverscrollController.cpp

@@ -67,9 +67,17 @@ void OverscrollController::HandleOverscroll(

if (delta_in_viewport != FloatSize()) {

accumulated_root_overscroll_ += delta_in_viewport;

- chrome_client_->DidOverscroll(delta_in_viewport,

- accumulated_root_overscroll_,

- position_in_viewport, velocity_in_viewport);

+ chrome_client_->DidOverscroll(

+ delta_in_viewport, accumulated_root_overscroll_, position_in_viewport,

+ velocity_in_viewport, scroll_boundary_behavior_);

+ }

+void OverscrollController::SetScrollBoundaryBehavior(

+ const WebScrollBoundaryBehavior& behavior) {

+ if (behavior != scroll_boundary_behavior_) {

+ scroll_boundary_behavior_ = behavior;

+ chrome_client_->SetScrollBoundaryBehavior(behavior);

}