Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(629)

Unified Diff: third_party/WebKit/Source/core/page/ChromeClientImpl.cpp

Issue 2884423003: Use scroll-boundary-behavior to control overscroll-refresh/glow on android. (Closed)
Patch Set: rebase Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/page/ChromeClientImpl.cpp
diff --git a/third_party/WebKit/Source/core/page/ChromeClientImpl.cpp b/third_party/WebKit/Source/core/page/ChromeClientImpl.cpp
index dd6e69a6b4af33b85ba0480fb2e7fc518e0857d3..bcea1ac3add116a3205b08b9b582731d96ab4a28 100644
--- a/third_party/WebKit/Source/core/page/ChromeClientImpl.cpp
+++ b/third_party/WebKit/Source/core/page/ChromeClientImpl.cpp
@@ -283,16 +283,18 @@ Page* ChromeClientImpl::CreateWindow(LocalFrame* frame,
return new_view->GetPage();
}
-void ChromeClientImpl::DidOverscroll(const FloatSize& overscroll_delta,
- const FloatSize& accumulated_overscroll,
- const FloatPoint& position_in_viewport,
- const FloatSize& velocity_in_viewport) {
+void ChromeClientImpl::DidOverscroll(
+ const FloatSize& overscroll_delta,
+ const FloatSize& accumulated_overscroll,
+ const FloatPoint& position_in_viewport,
+ const FloatSize& velocity_in_viewport,
+ const WebScrollBoundaryBehavior& behavior) {
if (!web_view_->Client())
return;
web_view_->Client()->DidOverscroll(overscroll_delta, accumulated_overscroll,
- position_in_viewport,
- velocity_in_viewport);
+ position_in_viewport, velocity_in_viewport,
+ behavior);
}
void ChromeClientImpl::Show(NavigationPolicy navigation_policy) {
@@ -1086,6 +1088,11 @@ void ChromeClientImpl::DidUpdateBrowserControls() const {
web_view_->DidUpdateBrowserControls();
}
+void ChromeClientImpl::SetScrollBoundaryBehavior(
+ const WebScrollBoundaryBehavior& scroll_boundary_behavior) {
+ web_view_->SetScrollBoundaryBehavior(scroll_boundary_behavior);
+}
+
void ChromeClientImpl::RegisterPopupOpeningObserver(
PopupOpeningObserver* observer) {
DCHECK(observer);

Powered by Google App Engine
This is Rietveld 408576698