Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5832)

Unified Diff: chrome/browser/ui/views/payments/contact_info_editor_view_controller_browsertest.cc

Issue 2884393002: [WebPayments] Adding FilterProfilesForShipping to profile comparator (Closed)
Patch Set: rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/views/payments/profile_list_view_controller_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/payments/contact_info_editor_view_controller_browsertest.cc
diff --git a/chrome/browser/ui/views/payments/contact_info_editor_view_controller_browsertest.cc b/chrome/browser/ui/views/payments/contact_info_editor_view_controller_browsertest.cc
index a9093df93ee608c0328127aa3d6c5e6977cf8cef..c79efe34feeab21753ce78a004cd8f1805fc1c12 100644
--- a/chrome/browser/ui/views/payments/contact_info_editor_view_controller_browsertest.cc
+++ b/chrome/browser/ui/views/payments/contact_info_editor_view_controller_browsertest.cc
@@ -237,8 +237,9 @@ IN_PROC_BROWSER_TEST_F(PaymentRequestContactInfoEditorTest,
OpenContactInfoScreen();
PaymentRequest* request = GetPaymentRequests(GetActiveWebContents()).front();
- EXPECT_EQ(request->state()->contact_profiles().front(),
- request->state()->selected_contact_profile());
+
+ // No contact profiles are selected because both are incomplete.
+ EXPECT_EQ(nullptr, request->state()->selected_contact_profile());
views::View* list_view = dialog_view()->GetViewByID(
static_cast<int>(DialogViewID::CONTACT_INFO_SHEET_LIST_VIEW));
@@ -269,6 +270,7 @@ IN_PROC_BROWSER_TEST_F(PaymentRequestContactInfoEditorTest,
profile->GetInfo(autofill::AutofillType(autofill::EMAIL_ADDRESS),
GetLocale()));
+ // Expect the newly-completed profile to be selected.
EXPECT_EQ(2U, request->state()->contact_profiles().size());
EXPECT_EQ(request->state()->contact_profiles().back(), profile);
}
« no previous file with comments | « no previous file | chrome/browser/ui/views/payments/profile_list_view_controller_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698