Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Unified Diff: webrtc/media/engine/webrtcvideoengine2.h

Issue 2882433003: Reduce VideoSendStream recreations due to FlexFEC. (Closed)
Patch Set: perkj comments 1. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/media/engine/webrtcvideoengine2.cc » ('j') | webrtc/media/engine/webrtcvideoengine2.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/media/engine/webrtcvideoengine2.h
diff --git a/webrtc/media/engine/webrtcvideoengine2.h b/webrtc/media/engine/webrtcvideoengine2.h
index 2c7d36ccb5cc820b5d20fa6317d1dbc950ca0f49..616c0dbfa79b4a3f94b49f40ce8c43c2a089647f 100644
--- a/webrtc/media/engine/webrtcvideoengine2.h
+++ b/webrtc/media/engine/webrtcvideoengine2.h
@@ -250,7 +250,8 @@ class WebRtcVideoChannel2 : public VideoMediaChannel, public webrtc::Transport {
int max_bitrate_bps,
const rtc::Optional<VideoCodecSettings>& codec_settings,
const rtc::Optional<std::vector<webrtc::RtpExtension>>& rtp_extensions,
- const VideoSendParameters& send_params);
+ const VideoSendParameters& send_params,
+ bool map_flexfec_send);
virtual ~WebRtcVideoSendStream();
void SetSendParameters(const ChangedSendParameters& send_params);
@@ -452,8 +453,12 @@ class WebRtcVideoChannel2 : public VideoMediaChannel, public webrtc::Transport {
const webrtc::PacketOptions& options) override;
bool SendRtcp(const uint8_t* data, size_t len) override;
+ // If |map_flexfec| is true and if the "flexfec-03" SDP codec exists in
+ // |codecs|, its payload type will be mapped to the VideoCodecSettings of the
perkj_webrtc 2017/05/12 12:05:06 /s all ?
brandtr 2017/05/15 12:24:13 Moved the logic instead.
+ // media codecs.
static std::vector<VideoCodecSettings> MapCodecs(
- const std::vector<VideoCodec>& codecs);
+ const std::vector<VideoCodec>& codecs,
+ bool map_flexfec);
// Select what video codec will be used for sending, i.e. what codec is used
// for local encoding, based on supported remote codecs. The first remote
// codec that is supported locally will be selected.
@@ -503,6 +508,9 @@ class WebRtcVideoChannel2 : public VideoMediaChannel, public webrtc::Transport {
VideoOptions default_send_options_;
VideoRecvParameters recv_params_;
int64_t last_stats_log_ms_;
+
+ const bool map_flexfec_recv_;
perkj_webrtc 2017/05/12 12:05:05 Can we add a comment what these two means?
brandtr 2017/05/15 12:24:13 Removed instead.
+ const bool map_flexfec_send_;
};
} // namespace cricket
« no previous file with comments | « no previous file | webrtc/media/engine/webrtcvideoengine2.cc » ('j') | webrtc/media/engine/webrtcvideoengine2.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698