Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(747)

Issue 2878853002: Make CSSVariableResolver's interface object based instead of static functions (Closed)

Created:
3 years, 7 months ago by alancutter (OOO until 2018)
Modified:
3 years, 6 months ago
Reviewers:
nainar, nainar1
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, Eric Willigers, rjwright, rwlbuis, shans
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make CSSVariableResolver's interface object based instead of static functions This change removes the static method interface from CSSVariableResolver. Users of the class now need to instantiate an instance of it to use its functionality. This change is in preparation for making variable resolution co-recursive with registered custom property animation application. The object interface is required to be able to persist variable resolution state throughout the recursion. This patch introduces no changes in behaviour. BUG=671904 Review-Url: https://codereview.chromium.org/2878853002 Cr-Commit-Position: refs/heads/master@{#476187} Committed: https://chromium.googlesource.com/chromium/src/+/4b4a8df39a1778fc1c2d4a9809c4ad976dcf378a

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -73 lines) Patch
M third_party/WebKit/Source/core/animation/CSSInterpolationType.cpp View 1 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.h View 1 2 chunks +12 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.cpp View 1 5 chunks +30 lines, -48 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 24 (19 generated)
alancutter (OOO until 2018)
3 years, 7 months ago (2017-05-26 01:30:50 UTC) #4
alancutter (OOO until 2018)
Redirecting review as timloh no longer works on style code.
3 years, 7 months ago (2017-05-26 06:17:00 UTC) #6
nainar
lgtm
3 years, 7 months ago (2017-05-26 06:39:36 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2878853002/20001
3 years, 6 months ago (2017-06-01 04:17:23 UTC) #21
commit-bot: I haz the power
3 years, 6 months ago (2017-06-01 04:20:38 UTC) #24
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4b4a8df39a1778fc1c2d4a9809c4...

Powered by Google App Engine
This is Rietveld 408576698