Move webrtc/video_frame to common_video/include.

webrtc/BUILD.gn

Index: webrtc/BUILD.gn
diff --git a/webrtc/BUILD.gn b/webrtc/BUILD.gn
index db0c067209f355a453e37d2484f410f83d82afea..6f89f80f18e2342427625e5c9638ee64f1c40e60 100644
--- a/webrtc/BUILD.gn
+++ b/webrtc/BUILD.gn
@@ -231,6 +231,17 @@ rtc_source_set("video_stream_api") {
   ]
 }
 
+# Contents of video_frame.h is moved from top-level down to common_video/.
+# Nothing in webrtc includes the backwards-compatibility header, so this target
+# is only for completeness.
+# TODO(nisse): Delete together with the header file once downstream applications
+# no longer use it.
+rtc_source_set("video_frame_deprecated") {
+  sources = [
+    "video_frame.h",
+  ]
+}

[kwiberg-webrtc, 2017/05/15 07:27:04]

Hmm. This source_set should have a dep on the target the moved .h file belongs
to, right? I would've thought gn check would flag that...

[mbonadei, 2017/05/15 07:31:56]

Yes, you are right.

Gn is not catching this because in the .gn file we are not checking the webrtc
directory [1].
We will do it soon. We have to land [2] and then we will enable it on
the whole codebase.

This is a good catch. Thanks!

[1] - https://chromium.googlesource.com/external/webrtc/+/master/.gn#24
[2] - https://codereview.webrtc.org/2845323002/

[nisse-webrtc, 2017/05/15 08:32:55]

Added dependency.

+
 if (!build_with_chromium) {
   # Target to build all the WebRTC production code.
   rtc_static_library("webrtc") {