Move webrtc/video_frame to common_video/include.

webrtc/BUILD.gn

 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
 #
 # Use of this source code is governed by a BSD-style license
 # that can be found in the LICENSE file in the root of the source
 # tree. An additional intellectual property rights grant can be found
 # in the file PATENTS.  All contributing project authors may
 # be found in the AUTHORS file in the root of the source tree.
 
 # TODO(kjellander): Rebase this to webrtc/build/common.gypi changes after r6330.
 
@@ skipping 213 matching lines @@
   libs = [ "Foundation.framework" ]
 }
 
 rtc_source_set("video_stream_api") {
   sources = [
     "video_receive_stream.h",
     "video_send_stream.h",
   ]
 }
 
+# Contents of video_frame.h is moved from top-level down to common_video/.
+# Nothing in webrtc includes the backwards-compatibility header, so this target
+# is only for completeness.
+# TODO(nisse): Delete together with the header file once downstream applications
+# no longer use it.
+rtc_source_set("video_frame_deprecated") {
+  sources = [
+    "video_frame.h",
+  ]
+}

[kwiberg-webrtc, 2017/05/15 07:27:04]

Hmm. This source_set should have a dep on the target the moved .h file belongs
to, right? I would've thought gn check would flag that...

[mbonadei, 2017/05/15 07:31:56]

Yes, you are right.

Gn is not catching this because in the .gn file we are not checking the webrtc
directory [1].
We will do it soon. We have to land [2] and then we will enable it on
the whole codebase.

This is a good catch. Thanks!

[1] - https://chromium.googlesource.com/external/webrtc/+/master/.gn#24
[2] - https://codereview.webrtc.org/2845323002/

[nisse-webrtc, 2017/05/15 08:32:55]

Added dependency.

+
 if (!build_with_chromium) {
   # Target to build all the WebRTC production code.
   rtc_static_library("webrtc") {
     # Only the root target should depend on this.
     visibility = [ "//:default" ]
 
     sources = [
       # TODO(ossu): Keep this here until donwstream projects have updated.
       # http://bugs.webrtc.org/6716
       "call.h",
@@ skipping 268 matching lines @@
       ]
 
       deps = [
         "//base:base_java_test_support",
         "//webrtc/examples:AppRTCMobile_javalib",
         "//webrtc/sdk/android:libjingle_peerconnection_java",
       ]
     }
   }
 }