Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Unified Diff: webrtc/base/string_to_number.cc

Issue 2877023002: Move webrtc/{base => rtc_base} (Closed)
Patch Set: update presubmit.py and DEPS include rules Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/base/string_to_number.h ('k') | webrtc/base/string_to_number_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/base/string_to_number.cc
diff --git a/webrtc/base/string_to_number.cc b/webrtc/base/string_to_number.cc
deleted file mode 100644
index b8e969daa42267de37459b096c789d444b4de263..0000000000000000000000000000000000000000
--- a/webrtc/base/string_to_number.cc
+++ /dev/null
@@ -1,50 +0,0 @@
-/*
- * Copyright 2017 The WebRTC Project Authors. All rights reserved.
- *
- * Use of this source code is governed by a BSD-style license
- * that can be found in the LICENSE file in the root of the source
- * tree. An additional intellectual property rights grant can be found
- * in the file PATENTS. All contributing project authors may
- * be found in the AUTHORS file in the root of the source tree.
- */
-
-#include <cerrno>
-#include <cstdlib>
-
-#include "webrtc/base/string_to_number.h"
-
-namespace rtc {
-namespace string_to_number_internal {
-
-rtc::Optional<signed_type> ParseSigned(const char* str, int base) {
- RTC_DCHECK(str);
- if (isdigit(str[0]) || str[0] == '-') {
- char* end = nullptr;
- errno = 0;
- const signed_type value = std::strtoll(str, &end, base);
- if (end && *end == '\0' && errno == 0) {
- return rtc::Optional<signed_type>(value);
- }
- }
- return rtc::Optional<signed_type>();
-}
-
-rtc::Optional<unsigned_type> ParseUnsigned(const char* str, int base) {
- RTC_DCHECK(str);
- if (isdigit(str[0]) || str[0] == '-') {
- // Explicitly discard negative values. std::strtoull parsing causes unsigned
- // wraparound. We cannot just reject values that start with -, though, since
- // -0 is perfectly fine, as is -0000000000000000000000000000000.
- const bool is_negative = str[0] == '-';
- char* end = nullptr;
- errno = 0;
- const unsigned_type value = std::strtoull(str, &end, base);
- if (end && *end == '\0' && errno == 0 && (value == 0 || !is_negative)) {
- return rtc::Optional<unsigned_type>(value);
- }
- }
- return rtc::Optional<unsigned_type>();
-}
-
-} // namespace string_to_number_internal
-} // namespace rtc
« no previous file with comments | « webrtc/base/string_to_number.h ('k') | webrtc/base/string_to_number_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698