Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: webrtc/base/random.h

Issue 2877023002: Move webrtc/{base => rtc_base} (Closed)
Patch Set: update presubmit.py and DEPS include rules Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/base/race_checker.cc ('k') | webrtc/base/random.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/base/random.h
diff --git a/webrtc/base/random.h b/webrtc/base/random.h
index cb7b9ebe4a7d90778671ae6f2eda2b5ca32fd2cb..12a490202bb6797952355d0bbac8bd1b7825bb20 100644
--- a/webrtc/base/random.h
+++ b/webrtc/base/random.h
@@ -11,83 +11,9 @@
#ifndef WEBRTC_BASE_RANDOM_H_
#define WEBRTC_BASE_RANDOM_H_
-#include <limits>
-#include "webrtc/typedefs.h"
-#include "webrtc/base/constructormagic.h"
-#include "webrtc/base/checks.h"
-
-namespace webrtc {
-
-class Random {
- public:
- // TODO(tommi): Change this so that the seed can be initialized internally,
- // e.g. by offering two ways of constructing or offer a static method that
- // returns a seed that's suitable for initialization.
- // The problem now is that callers are calling clock_->TimeInMicroseconds()
- // which calls TickTime::Now().Ticks(), which can return a very low value on
- // Mac and can result in a seed of 0 after conversion to microseconds.
- // Besides the quality of the random seed being poor, this also requires
- // the client to take on extra dependencies to generate a seed.
- // If we go for a static seed generator in Random, we can use something from
- // webrtc/base and make sure that it works the same way across platforms.
- // See also discussion here: https://codereview.webrtc.org/1623543002/
- explicit Random(uint64_t seed);
-
- // Return pseudo-random integer of the specified type.
- // We need to limit the size to 32 bits to keep the output close to uniform.
- template <typename T>
- T Rand() {
- static_assert(std::numeric_limits<T>::is_integer &&
- std::numeric_limits<T>::radix == 2 &&
- std::numeric_limits<T>::digits <= 32,
- "Rand is only supported for built-in integer types that are "
- "32 bits or smaller.");
- return static_cast<T>(NextOutput());
- }
-
- // Uniformly distributed pseudo-random number in the interval [0, t].
- uint32_t Rand(uint32_t t);
-
- // Uniformly distributed pseudo-random number in the interval [low, high].
- uint32_t Rand(uint32_t low, uint32_t high);
-
- // Uniformly distributed pseudo-random number in the interval [low, high].
- int32_t Rand(int32_t low, int32_t high);
-
- // Normal Distribution.
- double Gaussian(double mean, double standard_deviation);
-
- // Exponential Distribution.
- double Exponential(double lambda);
-
- private:
- // Outputs a nonzero 64-bit random number.
- uint64_t NextOutput() {
- state_ ^= state_ >> 12;
- state_ ^= state_ << 25;
- state_ ^= state_ >> 27;
- RTC_DCHECK(state_ != 0x0ULL);
- return state_ * 2685821657736338717ull;
- }
-
- uint64_t state_;
-
- RTC_DISALLOW_IMPLICIT_CONSTRUCTORS(Random);
-};
-
-// Return pseudo-random number in the interval [0.0, 1.0).
-template <>
-float Random::Rand<float>();
-
-// Return pseudo-random number in the interval [0.0, 1.0).
-template <>
-double Random::Rand<double>();
-
-// Return pseudo-random boolean value.
-template <>
-bool Random::Rand<bool>();
-
-} // namespace webrtc
+// This header is deprecated and is just left here temporarily during
+// refactoring. See https://bugs.webrtc.org/7634 for more details.
+#include "webrtc/rtc_base/random.h"
#endif // WEBRTC_BASE_RANDOM_H_
« no previous file with comments | « webrtc/base/race_checker.cc ('k') | webrtc/base/random.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698