Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Side by Side Diff: webrtc/base/asyncinvoker.h

Issue 2876273002: Fixing race between ~AsyncInvoker and ~AsyncClosure. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | webrtc/base/asyncinvoker.cc » ('j') | webrtc/base/asyncinvoker.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2014 The WebRTC Project Authors. All rights reserved. 2 * Copyright 2014 The WebRTC Project Authors. All rights reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 138 matching lines...) Expand 10 before | Expand all | Expand 10 after
149 void DoInvoke(const Location& posted_from, 149 void DoInvoke(const Location& posted_from,
150 Thread* thread, 150 Thread* thread,
151 std::unique_ptr<AsyncClosure> closure, 151 std::unique_ptr<AsyncClosure> closure,
152 uint32_t id); 152 uint32_t id);
153 void DoInvokeDelayed(const Location& posted_from, 153 void DoInvokeDelayed(const Location& posted_from,
154 Thread* thread, 154 Thread* thread,
155 std::unique_ptr<AsyncClosure> closure, 155 std::unique_ptr<AsyncClosure> closure,
156 uint32_t delay_ms, 156 uint32_t delay_ms,
157 uint32_t id); 157 uint32_t id);
158 volatile int pending_invocations_ = 0; 158 volatile int pending_invocations_ = 0;
159 Event invocation_complete_;
160 bool destroying_ = false; 159 bool destroying_ = false;
161 friend class AsyncClosure; 160 friend class AsyncClosure;
162 161
163 RTC_DISALLOW_COPY_AND_ASSIGN(AsyncInvoker); 162 RTC_DISALLOW_COPY_AND_ASSIGN(AsyncInvoker);
164 }; 163 };
165 164
166 // Similar to AsyncInvoker, but guards against the Thread being destroyed while 165 // Similar to AsyncInvoker, but guards against the Thread being destroyed while
167 // there are outstanding dangling pointers to it. It will connect to the current 166 // there are outstanding dangling pointers to it. It will connect to the current
168 // thread in the constructor, and will get notified when that thread is 167 // thread in the constructor, and will get notified when that thread is
169 // destroyed. After GuardedAsyncInvoker is constructed, it can be used from 168 // destroyed. After GuardedAsyncInvoker is constructed, it can be used from
(...skipping 79 matching lines...) Expand 10 before | Expand all | Expand 10 after
249 void ThreadDestroyed(); 248 void ThreadDestroyed();
250 249
251 CriticalSection crit_; 250 CriticalSection crit_;
252 Thread* thread_ GUARDED_BY(crit_); 251 Thread* thread_ GUARDED_BY(crit_);
253 AsyncInvoker invoker_ GUARDED_BY(crit_); 252 AsyncInvoker invoker_ GUARDED_BY(crit_);
254 }; 253 };
255 254
256 } // namespace rtc 255 } // namespace rtc
257 256
258 #endif // WEBRTC_BASE_ASYNCINVOKER_H_ 257 #endif // WEBRTC_BASE_ASYNCINVOKER_H_
OLDNEW
« no previous file with comments | « no previous file | webrtc/base/asyncinvoker.cc » ('j') | webrtc/base/asyncinvoker.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698