PRESUBMIT.py - Issue 2876043002: Disabling orphan headers presubmit check - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(138)

My Issues | Starred Open | Closed | All

Unified Diff: PRESUBMIT.py

Issue 2876043002: Disabling orphan headers presubmit check (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: PRESUBMIT.py

diff --git a/PRESUBMIT.py b/PRESUBMIT.py

index e2d0dd50d092b8699e208273f40864e6061a4d0a..e1dec872b147c982a96cd3d90ec54a2643d84f4e 100755

--- a/PRESUBMIT.py

+++ b/PRESUBMIT.py

@@ -575,7 +575,10 @@ def _CommonChecks(input_api, output_api):

results.extend(_CheckJSONParseErrors(input_api, output_api))

results.extend(_RunPythonTests(input_api, output_api))

results.extend(_CheckUsageOfGoogleProtobufNamespace(input_api, output_api))

- results.extend(_CheckOrphanHeaders(input_api, output_api))

+ # Disabling this because it seems to have a bug when running on Windows.

+ # TODO(mbonadei): fix this and re-enable this check.

+ # BUG: https://bugs.chromium.org/p/webrtc/issues/detail?id=7635

+ # results.extend(_CheckOrphanHeaders(input_api, output_api))

return results

« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine

This is Rietveld 408576698